all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox_dart_api_client 0/2] fix: ios: add support for custom user certificates
Date: Wed, 17 Sep 2025 10:35:47 +0200	[thread overview]
Message-ID: <DCUXS353OF44.2TCRIG1U97LAK@proxmox.com> (raw)
In-Reply-To: <ad8dc79d-908e-45ae-b7e0-87654e72001a@proxmox.com>

Sure i will sent it again. 

On Wed Sep 17, 2025 at 10:05 AM CEST, Dominik Csapak wrote:
> after applying the other series, this does not seem to apply anymore, 
> can you send a rebased one please?
>
> thanks
>
> On 9/8/25 4:11 PM, Shan Shaji wrote:
>> The app was not honoring the user installed certificate and was still
>> throwing `HandShakeException` when using `IOClient`. Inorder to fix the
>> issue used the `cupertino_http` package. This patch series only includes
>> the changes specific to iOS. Android related changes can be found here
>> [0].
>> 
>> - [0] https://lore.proxmox.com/pve-devel/DCKQF7FSYTGT.HK16P9PBZEDS@proxmox.com/T/#t
>> 
>> I've only tested the changes in the simulator so far. I'll also deploy
>> the changes to TestFlight and verify everything on a real device as well.
>> 
>> Shan Shaji (2):
>>    fix: ios: use `cupertino_http` package to honor custom user certificates
>>    fix: ios: add explicit throw of `HandshakeException`
>> 
>>   lib/src/authenticate.dart | 35 ++++++++++-----
>>   lib/src/utils_native.dart |  7 +++
>>   pubspec.lock              | 89 ++++++++++++++++++++++++++++++++++++---
>>   pubspec.yaml              |  1 +
>>   4 files changed, 115 insertions(+), 17 deletions(-)
>> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-09-17  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 14:11 Shan Shaji
2025-09-08 14:11 ` [pve-devel] [PATCH proxmox_dart_api_client 1/2] fix: ios: use `cupertino_http` package to honor " Shan Shaji
2025-09-08 14:11 ` [pve-devel] [PATCH proxmox_dart_api_client 2/2] fix: ios: add explicit throw of `HandshakeException` Shan Shaji
2025-09-09  9:58 ` [pve-devel] [PATCH proxmox_dart_api_client 0/2] fix: ios: add support for custom user certificates Shan Shaji
2025-09-17  8:05 ` Dominik Csapak
2025-09-17  8:35   ` Shan Shaji [this message]
2025-09-17 12:08     ` Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCUXS353OF44.2TCRIG1U97LAK@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal