From: "Daniel Kral" <d.kral@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container/guest-common/qemu-server v2 0/8] fix #1964: Add a setting to globally disable freezing a guest
Date: Tue, 02 Sep 2025 17:36:52 +0200 [thread overview]
Message-ID: <DCIFCBNY4XLM.UWW5WW7T7611@proxmox.com> (raw)
In-Reply-To: <20250902124524.368080-1-m.sandoval@proxmox.com>
On Tue Sep 2, 2025 at 2:45 PM CEST, Maximiliano Sandoval wrote:
> ..and add more logging when issuing fsfreeze guest commands.
>
> The setting takes preference over freeze-fs-on-backup and deprecates the former.
>
> At the moment taking a snapshot without RAM does not log whether there was a freeze/thaw.
>
> - The patch does result in an extra log line when making a Backup in snapshot mode.
>
> Differences from v1:
> - Add setting to enable/disable fsfreeze commands
> - Change wording in one log message
Tested the series with a VM and a container and it worked as was
expected for both. Tested that guest-fsfreeze=0 correctly overrides
fs-freeze-on-backup too and checked that all the log messages appear for
backups, clones, and snapshots with vmstate=0.
Didn't have a cluster ready today where I could check whether the option
is also correctly checked for replication too, but I'll see that I get
to that tomorrow.
With the few inline comments addressed, consider this:
Tested-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-02 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 12:45 Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 1/6] add a guest-fsfreeze qga setting Maximiliano Sandoval
2025-09-02 14:43 ` Daniel Kral
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 2/6] block job: mirror: follow guest-fsfreeze setting Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 3/6] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 4/6] log when issuing a guest-fsfreeze command Maximiliano Sandoval
2025-09-02 14:47 ` Daniel Kral
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 5/6] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 6/6] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2025-09-02 14:47 ` Daniel Kral
2025-09-02 12:45 ` [pve-devel] [PATCH container v2 1/1] log when freezing/thawing filesystem Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH guest-common v2 1/1] replication: remove logging when freezing/thawing Maximiliano Sandoval
2025-09-02 15:36 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCIFCBNY4XLM.UWW5WW7T7611@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.