Re: [pve-devel] [PATCH] ha: Correct in-text references to Available HA Rule Types

["Daniel Kral" <d.kral@proxmox.com>]

On Tue Sep 2, 2025 at 1:48 PM CEST, abobakr mohammed wrote:
> Corrected the descriptions of affinity rules in Table 2 (they were previously reversed).
> Changed "seperate" to "negative".
>
> Signed-off-by: abobakr mohammed <a.mohammed@proxmox.com>

Thanks for spotting this and sending a patch!

A few small points:

The PATCH in the subject line should be "PATCH pve-docs" or just
"PATCH docs", so everyone knows which repository it belongs to ;). You
can do that by using

    git format-patch --subject-prefix="PATCH docs" -v2 ...

when formatting the patch. We usually use only lowercase for the subject
line too, but that's more nit-picking from my side.

The commit message should be imperative (e.g. "Change X to Y" instead of
"Changes/Changed X to Y") and the line length must not be longer than 72
characters. See [0] for more information.

[0] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

With those addressed, consider this as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel