all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>
Cc: pdm-devel <pdm-devel-bounces@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v4 00/23] improve remote wizard
Date: Fri, 22 Aug 2025 15:30:48 +0200	[thread overview]
Message-ID: <DC8ZRT526AMO.2HBG97LTDEWBV@proxmox.com> (raw)
In-Reply-To: <20250822085409.1139639-1-d.csapak@proxmox.com>

On Fri Aug 22, 2025 at 10:32 AM CEST, Dominik Csapak wrote:
> # Summary
>
> This series improves the remote wizard in various points:
> * improved wording and texts
> * moved seperate buttons on pages into the next button
> * probing of entered nodes
> * confirmation dialog for missing fingerprints
> * better realm selector
>
> ## Probing on the server side
>
> I tried to determine if we need a fingerprint for nodes inside the
> API call, by probing each node. Since we currently only get the
> nodenames and not FQDNs in the nodelist, this will currently not
> result in a valid connection in most cases and return the fingerprint.
>
> My plan would be to include FQDNs of the nodes on the PVE side API call,
> so we can return here a list of nodename, ip and FQDNs, which the user
> then can select from. (which of those I'd probe on first check is yet
> to be determined)
>
> # Future work
>
> The next step for the wizard is to have some kind of quick copy&paste
> info. After discussing off-list with Fabian a bit, I think it would be
> best for this to contain the hostname (FQDN?) + fingerprint (if just a
> self-signed certificate) + a list of nodes with their respective
> nodename + FQDNs (maybe requires api change on PVE side to generate
> this). The user would then still have to do most of the steps currently
> necessary in the wizard, except the manual copy & pasting of
> fingerprints and maybe entering of FQDNs.
>
> changes from v3:
> * fixed outdated doc comments
> * disable realm selector when using a token directly
> * only rescan host / for nodes whent he previous form changed

Looks good to me now:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-08-22 13:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  8:32 Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 01/23] server/ui: pve: change 'realm list' api call to GET Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 02/23] api types: RemoteType: put default port info to the type Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 03/23] server: connection: add probe_tls_connection helper Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 04/23] server: add probe-tls endpoint Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 05/23] server: pve api: extend 'scan' so it tls-probes the nodes Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 06/23] pdm-client: add scan_remote and probe_tls methods Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 07/23] ui: remotes: node url list: add placeholder and clear trigger Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 08/23] ui: remotes: node url list: make column header clearer Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 09/23] ui: remotes: node url list: handle changing default Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 10/23] ui: pve wizard: rename 'realm' variable to 'info' Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 11/23] ui: pve wizard: summary: add default text for fingerprint Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 12/23] ui: pve wizard: nodes: improve info text Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 13/23] ui: pve wizard: nodes: probe hosts to verify fingerprint settings Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 14/23] ui: pve wizard: info: use pdm_client for scanning Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 15/23] ui: pve wizard: info: detect hostname and fingerprint Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 16/23] ui: pve wizard: info: remove manual scan button Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 17/23] ui: widget: add pve realm selector Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 18/23] ui: pve wizard: info: use " Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 19/23] ui: pve wizard: connect: factor out normalize_hostname Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 20/23] ui: pve wizard: connect: move connection logic to next button Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 21/23] ui: pve wizard: connect: reset later pages when form changes Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 22/23] ui: pve wizard: connect: use scan api endpoint instead of realms Dominik Csapak
2025-08-22  8:32 ` [pdm-devel] [PATCH datacenter-manager v4 23/23] ui: pve wizard: connect: add certificate confirmation dialog Dominik Csapak
2025-08-22 13:30 ` Lukas Wagner [this message]
2025-08-22 14:07 ` [pdm-devel] applied: [PATCH datacenter-manager v4 00/23] improve remote wizard Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC8ZRT526AMO.2HBG97LTDEWBV@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel-bounces@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal