all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 03/23] server: connection: add probe_tls_connection helper
Date: Thu, 21 Aug 2025 13:46:01 +0200	[thread overview]
Message-ID: <DC82X1AASPG4.2VZGKFWGUCU3E@proxmox.com> (raw)
In-Reply-To: <20250821084229.1523597-4-d.csapak@proxmox.com>

On Thu Aug 21, 2025 at 10:39 AM CEST, Dominik Csapak wrote:
> +/// Checks TLS connection to the given remote
> +///
> +/// Returns `Ok(None)` if connecting with the given parameters works
> +/// Returns `Ok(Some(cert))` if no fingerprint was given and some certificate could not be validated
> +/// Returns `Err(err)` if some other error occurred
> +///
> +/// # Example
> +///
> +/// ```
> +/// use server::connection::probe_tls_connection;
> +/// use pdm_api_types::remotes::RemoteType;
> +///
> +/// # async fn function() {
> +/// let result = probe_tls_connection(RemoteType::Pve, "192.168.2.100".to_string(), None).await;
> +/// match result {
> +///     Ok(None) => { /* everything ok */ },
> +///     Ok(Some(cert)) => { /* do something with cert */ },
> +///     Err(err) => { /* do something with error */ },
> +/// }
> +/// # }
> +/// ```

^ The doc comment is now outdated

> +pub async fn probe_tls_connection(
> +    remote_type: RemoteType,
> +    hostname: String,
> +    fingerprint: Option<String>,
> +) -> Result<TlsProbeOutcome, Error> {
> +    let host_port: Authority = hostname.parse()?;
> +
> +    let uri: http::uri::Uri = format!(
> +        "https://{}:{}",
> +        host_port.host(),
> +        host_port.port_u16().unwrap_or(remote_type.default_port())
> +    )
> +    .parse()?;



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-08-21 11:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  8:39 [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 01/23] server/ui: pve: change 'realm list' api call to GET Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 02/23] api types: RemoteType: put default port info to the type Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 03/23] server: connection: add probe_tls_connection helper Dominik Csapak
2025-08-21 11:46   ` Lukas Wagner [this message]
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 04/23] server: add probe-tls endpoint Dominik Csapak
2025-08-21 11:46   ` Lukas Wagner
2025-08-21 11:55     ` Dominik Csapak
2025-08-21 11:58       ` Lukas Wagner
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 05/23] server: pve api: extend 'scan' so it tls-probes the nodes Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 06/23] pdm-client: add scan_remote and probe_tls methods Dominik Csapak
2025-08-21 11:46   ` Lukas Wagner
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 07/23] ui: remotes: node url list: add placeholder and clear trigger Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 08/23] ui: remotes: node url list: make column header clearer Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 09/23] ui: remotes: node url list: handle changing default Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 10/23] ui: pve wizard: rename 'realm' variable to 'info' Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 11/23] ui: pve wizard: summary: add default text for fingerprint Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 12/23] ui: pve wizard: nodes: improve info text Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 13/23] ui: pve wizard: nodes: probe hosts to verify fingerprint settings Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 14/23] ui: pve wizard: info: use pdm_client for scanning Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 15/23] ui: pve wizard: info: detect hostname and fingerprint Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 16/23] ui: pve wizard: info: remove manual scan button Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 17/23] ui: widget: add pve realm selector Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 18/23] ui: pve wizard: info: use " Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 19/23] ui: pve wizard: connect: factor out normalize_hostname Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 20/23] ui: pve wizard: connect: move connection logic to next button Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 21/23] ui: pve wizard: connect: reset later pages when form changes Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 22/23] ui: pve wizard: connect: use scan api endpoint instead of realms Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 23/23] ui: pve wizard: connect: add certificate confirmation dialog Dominik Csapak
2025-08-21 11:45 ` [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard Lukas Wagner
2025-08-22  8:10   ` Thomas Lamprecht
2025-08-22  9:03 ` [pdm-devel] superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC82X1AASPG4.2VZGKFWGUCU3E@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal