From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v3] ui: enable noVNC console on iOS
Date: Thu, 14 Aug 2025 11:35:21 +0200 [thread overview]
Message-ID: <DC21R6CKGS7V.3VSN1EGQT7GKU@noor> (raw)
In-Reply-To: <DC1ZLWU4MIBD.2CQAI3CS8NIW@noor>
Superseded by v4: https://lore.proxmox.com/pve-devel/20250814093219.75803-1-s.shaji@proxmox.com/T/#u
On Thu Aug 14, 2025 at 9:54 AM CEST, Shan Shaji wrote:
> Thank you so much for the review. I am using the samne versions
> flutter 3.29 and dart 3.7.2. I will create another patch without
> the formating changes to better identify the changes.
>
> After the patch is applied i can send another patch by runnning
> the `dart format .` command on master.
>
> On Wed Aug 13, 2025 at 3:36 PM CEST, Dominik Csapak wrote:
> > is it possible to send dart format patches upfront and as a seperate patch?
> >
> > that way one can see the actual changes much more easily.
> >
> > also which version of dart/flutter do you use?
> > when i do `dart format` on that file here on current master,
> > it does not change the formatting at all
> > (but i'm still on flutter 3.29 with dart sdk on 3.7.2)
> >
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-14 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 8:29 Shan Shaji
2025-08-13 13:36 ` Dominik Csapak
2025-08-14 7:54 ` Shan Shaji
2025-08-14 9:35 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC21R6CKGS7V.3VSN1EGQT7GKU@noor \
--to=s.shaji@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.