From: "Hannes Duerr" <h.duerr@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/network v2 0/2] Improve FRR reloading logic
Date: Tue, 05 Aug 2025 11:43:15 +0200 [thread overview]
Message-ID: <DBUEABLIIOKH.2MEFKP2M97B4A@proxmox.com> (raw)
In-Reply-To: <20250805083504.55378-1-s.hanreich@proxmox.com>
Tested it by upgrading existing ceph full mesh cluster (without
fabrics) and reloading the network after succesful upgrade
Tested-by: Hannes Duerr <h.duerr@proxmox.com>
On Tue Aug 5, 2025 at 10:35 AM CEST, Stefan Hanreich wrote:
> Follow-up to the stop gap fix in [1].
>
> This should handle all cases that we need to consider:
>
> * Do not overwrite existing FRR configurations, unless we need to generate our
> own FRR configuration.
>
> * Do not trigger a FRR enable when reloading the host configuration, even though
> there is no FRR configuration.
>
> * Overwrite the FRR configuration with an empty configuration if all SDN
> entities using FRR got deleted.
>
> * Regenerate the FRR configuration when the host network configuration changes,
> since this might affect the generated FRR configuration.
>
> Changes from v1:
> * fix typo and improve wording of comments
>
>
> [1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=6c5295a1cdb6ec872ddf997cae030817dffff106
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-05 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 8:35 Stefan Hanreich
2025-08-05 8:35 ` [pve-devel] [PATCH pve-manager v2 1/1] network: improve " Stefan Hanreich
2025-08-05 8:35 ` [pve-devel] [PATCH pve-network v2 1/1] sdn: api: always send regenerate-frr parameter Stefan Hanreich
2025-08-05 8:36 ` [pve-devel] superseded: [PATCH manager/network v2 0/2] Improve FRR reloading logic Stefan Hanreich
2025-08-05 8:49 ` Stefan Hanreich
2025-08-05 9:22 ` [pve-devel] " Gabriel Goller
2025-08-05 9:43 ` Hannes Duerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBUEABLIIOKH.2MEFKP2M97B4A@proxmox.com \
--to=h.duerr@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.