From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Shannon Sterz" <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons
Date: Mon, 04 Aug 2025 13:20:33 +0200 [thread overview]
Message-ID: <DBTLQ9RDGDAA.Y90I44F9KI7J@proxmox.com> (raw)
In-Reply-To: <20250804105024.117020-1-s.sterz@proxmox.com>
On Mon Aug 4, 2025 at 12:50 PM CEST, Shannon Sterz wrote:
> previously we used custom png rendered icons for guests and storages
> in the add menu of a pool, as well as for mountpoints for containers.
> these appeared blurry on high resolution displays and since they were
> just the same as the font-awesome icons anyway, use those directly.
> the ui already loads font-awesome regardless, so there are no
> down-sides here.
>
LGTM!
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Verified that these three icons are indeed replaced with the
high-resolution version from FA:
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-04 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 10:50 Shannon Sterz
2025-08-04 11:20 ` Lukas Wagner [this message]
2025-08-04 11:48 ` Fiona Ebner
2025-08-04 12:10 ` Shannon Sterz
2025-08-04 12:28 ` Fiona Ebner
2025-08-26 15:00 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBTLQ9RDGDAA.Y90I44F9KI7J@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.