From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free
Date: Fri, 01 Aug 2025 15:04:39 +0200 [thread overview]
Message-ID: <DBR42C5GXEPT.3FABRK1ZF7OJY@proxmox.com> (raw)
In-Reply-To: <175405274372.2432529.8239150314582136063.b4-ty@proxmox.com>
On Fri Aug 1, 2025 at 2:52 PM CEST, Thomas Lamprecht wrote:
> Applied, thanks!
>
> But can you please add a cover-letter for any actual patch series (i.e., not
> just a single patch), as that provides some value even if it's empty, as it
> makes it very clear if trailers like T-b or R-b are intended for the full
> series or just a single patch out of it. b4 also uses the same logic to
> determine for which commits to apply the R-b and T-b too, so here I had to
> manually add Maximiliano's R-b and T-b to patch 2 to 5, as from b4's POV they
> where only supplied for patch 1/5.
>
> A diffstat over all patches is a side benefit, a short sentence as overview
> might be nice too, but for things like these here it can be even fine to not
> have that.
>
> Not a big thing, but would make my (and others using b4) life a bit easier and
> better ensure that tests and reviews get encoded into git, providing some
> recognition of that important work.
>
Okay, will keep this in mind for the future. Thanks for the hint and
explanation!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-01 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 9:54 Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 2/5] pmxcfs: status: avoid unnecessary string allocations Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 3/5] pmxcfs: status: call g_strdup instead of g_strdup_printf when no formatting is needed Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 4/5] pmxcfs: status: remove string literal params for g_strdup_printf Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 5/5] pmxcfs: status: avoid g_strdup when not needed Lukas Wagner
2025-08-01 11:32 ` [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free Maximiliano Sandoval
2025-08-01 12:52 ` Thomas Lamprecht
2025-08-01 13:04 ` Lukas Wagner [this message]
2025-08-01 12:55 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBR42C5GXEPT.3FABRK1ZF7OJY@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.