Re: [pve-devel] [RFC PATCH manager] migrate: fix conntrack migration and ha-resources checkbox

From: "Daniel Kral" <d.kral@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Gabriel Goller" <g.goller@proxmox.com>
Cc: pve-devel <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH manager] migrate: fix conntrack migration and ha-resources checkbox
Date: Fri, 01 Aug 2025 10:02:59 +0200	[thread overview]
Message-ID: <DBQXND1EKGND.1RZHWWJ4BUYHI@proxmox.com> (raw)
In-Reply-To: <cc9e1378-7f05-4942-9e9b-0eaf9797ffcd@proxmox.com>

On Fri Aug 1, 2025 at 9:35 AM CEST, Thomas Lamprecht wrote:
> Am 01.08.25 um 09:11 schrieb Daniel Kral:
>> Another even simpler version that we use in the function already (e.g.
>> right above for blockingHAResources) is to just fallback to an empty
>> array, i.e.
>> 
>> let comigratedHAResources = migrateStats['comigrated-ha-resources'] ?? [];
>> if (comigratedHAResources.length) {
>> ...
>
> FWIW, the backend is wrongly setting this to an object by default, that
> might contribute to the error here, or even be its actual source!

Thanks for catching that! I forgot to change the type there as in v2 it
still was a hash (in get_{service,resource}_motion_info(...)).

>
> I'm fixing this up there and will also do a s/comigrated/dependent/ as
> that's what this actually describes, that these resources then normally
> also migrate is the result not the cause, and might change with node
> affinity rules being mixed with non-strict resource once in the future.
>
>> 
>> 
>> Either way, the fix should also be done for checkLxcPreconditions(...),
>> because there it's missing the check too.
>> 
> Will also take another look at the backend here.

Thanks!

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel