From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Friedrich Weber" <f.weber@proxmox.com>
Cc: pve-devel <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager] ui: RRD graphs: display PSI as percent
Date: Thu, 31 Jul 2025 16:08:37 +0200 [thread overview]
Message-ID: <DBQASRYKC4B1.2BBPLPLQIMQY@proxmox.com> (raw)
In-Reply-To: <175397021624.1346496.13388080887498120500.b4-ty@proxmox.com>
On Thu Jul 31, 2025 at 3:56 PM CEST, Thomas Lamprecht wrote:
> On Thu, 31 Jul 2025 15:51:42 +0200, Friedrich Weber wrote:
>> Pressure stall information are actually in percent. This is not
>> mentioned explicitly in the documentation, but e.g. in the kernel
>> source [1]:
>>
>> > The percentage of wall clock time spent in those compound stall
>> > states gives pressure numbers between 0 and 100 for each resource,
>> > where the SOME percentage indicates workload slowdowns and the FULL
>> > percentage indicates reduced CPU utilization:
>> >
>> > %SOME = time(SOME) / period
>> > %FULL = time(FULL) / period
>>
>> [...]
>
> This was a bit strange for me, I seemingly ingrained some wrong knownledge when
> getting first exposed to PSI when that was a new thing back in 2019 or so,
> either the docs where worded a bit differently or I just read a bit to much
> into the wording (more likely), anyhow thanks for clarifying this, one thing
> that I'm still wondering is this then percent for real (i.e. * 100 already) or
> a ratio? Or would we need to do *= 100 scaling?
>
> Anyway, as this restores the status quo with rationale it's already an
> improvement as is, so: Applied, thanks!
if i remember correctly and read the kernel documentation correctly,
this is proper percent (%) [1]. so no additional multiplying necessary.
> The ratios (in %) are tracked as recent trends over ten, sixty, and
> three hundred second windows, which gives insight into short term
> events as well as medium and long term trends.
also did i quick check here on my machine (by compiling pbs):
> ==> /proc/pressure/cpu <==
> some avg10=10.63 avg60=3.66 avg300=0.87 total=54165853
so the `avg10=10.63` should be percent.
[1]: https://www.kernel.org/doc/html/latest/accounting/psi.html
>
> [1/1] ui: RRD graphs: display PSI as percent
> commit: 2753e104a1e6effa4a0ae995f13636a02f3557af
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-31 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 13:51 [pve-devel] " Friedrich Weber
2025-07-31 13:56 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-31 14:06 ` Friedrich Weber
2025-07-31 14:08 ` Shannon Sterz [this message]
2025-07-31 14:09 ` Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBQASRYKC4B1.2BBPLPLQIMQY@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.