Re: [pve-devel] [PATCH-SERIES storage 0/3] fix #6587: lvm plugin: snapshot info: fix parsing snapshot name

["Max R. Carrara" <m.carrara@proxmox.com>]

On Wed Jul 30, 2025 at 6:20 PM CEST, Fiona Ebner wrote:
> Volume names are allowed to contain underscores, so it is impossible
> to determine the snapshot name from just the volume name, e.g:
> snap_vm-100-disk_with_underscore_here_s_some_more.qcow2
>
> Therefore, we need to also rely on the volume name itself to properly
> parse the snapshot name.

Did some testing and tried to break things.

Works as advertised and even fixes previously broken snapshots--that is,
if one tried to delete a snapshot on LVM before this patch, the snapshot
would become stuck in the "deleted" state. Once this patch was applied,
I was able to delete the stuck snapshot as well (after `qm unlock`,
naturally).

The changes also seem fine to me; gave patch 02 most of my attention
since that's where the fix is. Couldn't spot anything wrong with any of
the changes here.

So, LGTM -- consider:

Tested-by: Max R. Carrara <m.carrara@proxmox.com>
Reviewed-by: Max R. Carrara <m.carrara@proxmox.com>

>
> Fiona Ebner (3):
>   lvm plugin: snapshot info: avoid superfluous argument for closure
>   fix #6587: lvm plugin: snapshot info: fix parsing snapshot name
>   lvm plugin: volume snapshot: actually print error when renaming
>
>  src/PVE/Storage/LVMPlugin.pm | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel