all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Christian Ebner" <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation
Date: Wed, 30 Jul 2025 15:47:04 +0200	[thread overview]
Message-ID: <DBPFPQ7NJ1OZ.3IY6C2ZK7MYKN@proxmox.com> (raw)
In-Reply-To: <20250728064645.158414-1-c.ebner@proxmox.com>

On Mon Jul 28, 2025 at 8:46 AM CEST, Christian Ebner wrote:
> This patches aim to increase usability for the user by allowing to list
> accessible buckets during datastore creation.
>
> For this, the proxmox s3 client is extended by the list buckets method, fetching
> accessible buckets from the s3 api. This requires the client instantiation to be
> possible without the bucket name, making it therefore optional. Further, the
> regex for the config endpoint url must be restricted to have the bucket name
> template pattern always at the start of the template. With these changes, it is
> then possible to fetch the buckets given the required permissions to do so.
>
> On the proxmox backup server side, the api endpoints to fetch the bucket list
> are implemented as well as the corresponding cli command. Finally, the bucket
> name field in the datastore edit window is replaced by an s3 bucket selector,
> which loads the accessible bucket names via the api.
>

Already reported to Chris off-list, but there seems to be something
wrong in the response parser when multiple buckets are returned:

$ proxmox-backup-manager s3 endpoint list-buckets minio
Error: failed to list buckets

Caused by:
    0: failed to parse response body
    1: custom: duplicate field `Bucket`

If I remove all but one buckets from the MinIO server, it works.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-07-30 13:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28  6:46 Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 1/4] s3 client: restrict bucket template pattern to start of endpoint url Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 2/4] s3 client: make bucket name optional in S3 client options Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 3/4] s3 client: implement list buckets method Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 4/4] s3 client: api types: add bucket list item type Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 1/6] ui: fix formatting issues using proxmox-biome Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 2/6] datastore: wrap bucket name, as in is now optional in the s3 client Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 3/6] api: admin s3: make store prefix for check command optional Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 4/6] api: config s3: add bucket list api endpoint Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 5/6] bin: expose list buckets as proxmox-backup-manager s3 subcommand Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 6/6] ui: replace bucket field by bucket selector Christian Ebner
2025-07-30 13:47 ` Lukas Wagner [this message]
2025-07-30 14:25   ` [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation Christian Ebner
2025-07-30 14:00 ` Lukas Wagner
2025-07-30 14:41 ` [pbs-devel] superseded: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBPFPQ7NJ1OZ.3IY6C2ZK7MYKN@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal