Re: [pve-devel] [PATCH widget-toolkit v2 2/3] add context to translatable strings

["Shannon Sterz" <s.sterz@proxmox.com>]

On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/Utils.js                        | 2 ++
>  src/panel/NotificationConfigView.js | 1 +
>  src/window/ZFSDetail.js             | 1 +
>  3 files changed, 4 insertions(+)
>
> diff --git a/src/Utils.js b/src/Utils.js
> index 92cbf28..27fb69c 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -786,6 +786,7 @@ Ext.define('Proxmox.Utils', {
>
>          format_size: function (size, useSI) {
>              let unitsSI = [
> +                // TRANSLATORS: This the Bytes unit (e.g. 1B = 8 bits)

nit: this (and the same occurance below) are missing an "is", "This is
the Bytes unit [..]"

>                  gettext('B'),
>                  gettext('KB'),
>                  gettext('MB'),
> @@ -797,6 +798,7 @@ Ext.define('Proxmox.Utils', {
>                  gettext('YB'),
>              ];
>              let unitsIEC = [
> +                // TRANSLATORS: This the Bytes unit (e.g. 1B = 8 bits)
>                  gettext('B'),
>                  gettext('KiB'),
>                  gettext('MiB'),
> diff --git a/src/panel/NotificationConfigView.js b/src/panel/NotificationConfigView.js
> index 92e1f9b..85e45a0 100644
> --- a/src/panel/NotificationConfigView.js
> +++ b/src/panel/NotificationConfigView.js
> @@ -163,6 +163,7 @@ Ext.define('Proxmox.panel.NotificationEndpointView', {
>          },
>          {
>              dataIndex: 'name',
> +            // TRANSLATORS: As in "the target's name"
>              text: gettext('Target Name'),
>              renderer: Ext.String.htmlEncode,
>              flex: 2,
> diff --git a/src/window/ZFSDetail.js b/src/window/ZFSDetail.js
> index 1c63b5a..2617b87 100644
> --- a/src/window/ZFSDetail.js
> +++ b/src/window/ZFSDetail.js
> @@ -83,6 +83,7 @@ Ext.define('Proxmox.window.ZFSDetail', {
>                      renderer: Proxmox.Utils.render_zfs_health,
>                  },
>                  scan: {
> +                    // TRANSLATORS: This is a noun
>                      header: gettext('Scan'),
>                  },
>                  status: {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel