From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-access-control] fix #6528: tfa: update user config on removal of TFA
Date: Tue, 29 Jul 2025 13:06:44 +0200 [thread overview]
Message-ID: <DBOHOF6251H6.1782EFB5VTUT@noor> (raw)
In-Reply-To: <1753785610.otyyvk8ca5.astroid@yuna.none>
superseeded by v2: https://lore.proxmox.com/pve-devel/20250729110229.118959-1-s.shaji@proxmox.com/T/#u
On Tue Jul 29, 2025 at 12:40 PM CEST, Fabian Grünbichler wrote:
> > So the order will the lock TFA -> lock user cfg -> update user cfg ->
> > update tfa cfg.
>
> yes, unless you find another code path that does the inverse (lock user
> first, then lock TFA while the lock is held) - in that case we need to
> settle on one of the two variants ;)
I think it's not possible to do the other way around as when i checked
the implementaion of `lock_tfa_config` in PVE::AccessControl if the
user config is locked it's not possible to acquire a tfa lock. Also
there is a comment that mentions about locking of the files are only
allowed together in one order.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-29 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 8:30 Shan Shaji
2025-07-29 9:45 ` Fabian Grünbichler
2025-07-29 10:26 ` Shan Shaji
2025-07-29 10:40 ` Fabian Grünbichler
2025-07-29 11:06 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBOHOF6251H6.1782EFB5VTUT@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.