all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui
Date: Mon, 14 Jul 2025 15:49:51 +0200	[thread overview]
Message-ID: <DBBTR56PQUJW.WSIWN7LPLP0C@proxmox.com> (raw)
In-Reply-To: <20250714104235.2107690-1-d.csapak@proxmox.com>

Tested the series, came across two thing:

Given e.g. the following interface:

    11: ens8: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc [..]
	link/ether 01:02:03:04:05:06 brd ff:ff:ff:ff:ff:ff
	altname nic8
	altname enxdeadff02d073

and the following /etc/network/interfaces snippet:

    auto nic8
    iface nic8 inet manual

the interface will be displayed twice in the network page. If in the
above snippet s/nic8/ens8/ is done (i.e. using the primary name), it
works correctly.

I guess between our /e/n/i parser and the altname mapping the interface
is picked up twice, so this will need some sort of "de-duplication" in
the backend, from what I can gather.

---

Further, if an interface has at least two altnames (like above), the
ordering doesn't seem stable across API requests.

E.g. double-click on an interface, close the dialog -> the
altnames will switch around randomly in the table column.
Opening the dialog multiple times yields the same behaviour for the
altname textfield.

On Mon Jul 14, 2025 at 12:42 PM CEST, Dominik Csapak wrote:
> This series goes on top of Stefan Hahnreich's last series[0], but it seems
> there is still some things missing from INotify (to e.g. set the altnames via
> the api), so maybe the helper I introduce in the pve-manager patch will be
> unnecessary, depending if parsing the interfaces file will already return the
> altnames.
>
> Note that the pve-manager patch depends on the widget-toolkit patch
>
> 0: https://lore.proxmox.com/pve-devel/20250709194526.560709-2-s.hanreich@proxmox.com/
>
> proxmox-widget-toolkit:
>
> Dominik Csapak (1):
>   network: optionally show alternative interface names
>
>  src/node/NetworkEdit.js | 19 +++++++++++++++++++
>  src/node/NetworkView.js | 20 ++++++++++++++++++++
>  2 files changed, 39 insertions(+)
>
>
> pve-manager:
>
> Dominik Csapak (1):
>   api/ui: show/return alternative interface names
>
>  PVE/API2/Network.pm         | 32 ++++++++++++++++++++++++++++++--
>  www/manager6/node/Config.js |  1 +
>  2 files changed, 31 insertions(+), 2 deletions(-)
>
>
> Summary over all repositories:
>   4 files changed, 70 insertions(+), 2 deletions(-)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-14 13:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 10:42 Dominik Csapak
2025-07-14 10:42 ` [pve-devel] [PATCH widget-toolkit 1/1] network: optionally show alternative interface names Dominik Csapak
2025-07-14 10:42 ` [pve-devel] [PATCH pve-manager 1/1] api/ui: show/return " Dominik Csapak
2025-07-14 13:49 ` Christoph Heiss [this message]
2025-07-14 13:53   ` [pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui Dominik Csapak
2025-07-14 14:31     ` Thomas Lamprecht
2025-07-15  7:41       ` Dominik Csapak
2025-07-15  8:17         ` Thomas Lamprecht
2025-07-15  8:36           ` Dominik Csapak
2025-07-15  8:54             ` Thomas Lamprecht
2025-07-15  9:00               ` Dominik Csapak
2025-07-15  9:01                 ` Thomas Lamprecht
2025-07-15  9:08 ` [pve-devel] superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBBTR56PQUJW.WSIWN7LPLP0C@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal