all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
@ 2025-05-13 10:32 Shan Shaji
  2025-07-14 13:01 ` Shan Shaji
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Shan Shaji @ 2025-05-13 10:32 UTC (permalink / raw)
  To: pve-devel

The app was crashing on iOS when trying to access the biometric storage
to access the saved password. The crash was due to a missing key inside
the `Info.plist` file [0]. This patch fixes it by adding the missing
`NSFaceIDUsageDescription` key inside the `Info.plist` file.

- [0]
https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 ios/Runner/Info.plist | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
index ef3f061..825d78d 100644
--- a/ios/Runner/Info.plist
+++ b/ios/Runner/Info.plist
@@ -24,6 +24,8 @@
 	<string>$(FLUTTER_BUILD_NUMBER)</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
+	<key>NSFaceIDUsageDescription</key>
+	<string>Use Face ID for a faster and more convenient login experience.</string>
 	<key>UILaunchStoryboardName</key>
 	<string>LaunchScreen</string>
 	<key>UIMainStoryboardFile</key>
-- 
2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
  2025-05-13 10:32 [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist Shan Shaji
@ 2025-07-14 13:01 ` Shan Shaji
  2025-07-16 13:13 ` Aaron Lauterer
  2025-07-16 13:24 ` [pve-devel] applied: " Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Shan Shaji @ 2025-07-14 13:01 UTC (permalink / raw)
  To: Shan Shaji, pve-devel

Ping

On Tue May 13, 2025 at 12:32 PM CEST, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
>
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  ios/Runner/Info.plist | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
> index ef3f061..825d78d 100644
> --- a/ios/Runner/Info.plist
> +++ b/ios/Runner/Info.plist
> @@ -24,6 +24,8 @@
>  	<string>$(FLUTTER_BUILD_NUMBER)</string>
>  	<key>LSRequiresIPhoneOS</key>
>  	<true/>
> +	<key>NSFaceIDUsageDescription</key>
> +	<string>Use Face ID for a faster and more convenient login experience.</string>
>  	<key>UILaunchStoryboardName</key>
>  	<string>LaunchScreen</string>
>  	<key>UIMainStoryboardFile</key>
> -- 
> 2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
  2025-05-13 10:32 [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist Shan Shaji
  2025-07-14 13:01 ` Shan Shaji
@ 2025-07-16 13:13 ` Aaron Lauterer
  2025-07-16 13:24 ` [pve-devel] applied: " Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Aaron Lauterer @ 2025-07-16 13:13 UTC (permalink / raw)
  To: Proxmox VE development discussion, Shan Shaji

LGTM.

Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2025-05-13  12:32, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
> 
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   ios/Runner/Info.plist | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
> index ef3f061..825d78d 100644
> --- a/ios/Runner/Info.plist
> +++ b/ios/Runner/Info.plist
> @@ -24,6 +24,8 @@
>   	<string>$(FLUTTER_BUILD_NUMBER)</string>
>   	<key>LSRequiresIPhoneOS</key>
>   	<true/>
> +	<key>NSFaceIDUsageDescription</key>
> +	<string>Use Face ID for a faster and more convenient login experience.</string>
>   	<key>UILaunchStoryboardName</key>
>   	<string>LaunchScreen</string>
>   	<key>UIMainStoryboardFile</key>



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
  2025-05-13 10:32 [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist Shan Shaji
  2025-07-14 13:01 ` Shan Shaji
  2025-07-16 13:13 ` Aaron Lauterer
@ 2025-07-16 13:24 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-07-16 13:24 UTC (permalink / raw)
  To: pve-devel, Shan Shaji

On Tue, 13 May 2025 12:32:00 +0200, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
> 
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
> 
> [...]

Applied, thanks!

[1/1] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
      commit: cef02a66392ab651108fddd59d2d142e6a75133f


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-16 13:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-13 10:32 [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist Shan Shaji
2025-07-14 13:01 ` Shan Shaji
2025-07-16 13:13 ` Aaron Lauterer
2025-07-16 13:24 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal