From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Stefan Hanreich" <s.hanreich@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-firewall] firewall: show full error if rule apply fails
Date: Wed, 02 Jul 2025 15:53:50 +0200 [thread overview]
Message-ID: <DB1MBNIHOBYG.TZ38P2EATX0G@proxmox.com> (raw)
In-Reply-To: <ee7e2268-3295-46ac-ac91-58783a8d8961@proxmox.com>
On Wed Jul 2, 2025 at 3:42 PM CEST, Stefan Hanreich wrote:
> On 6/30/25 13:23, Christoph Heiss wrote:
>> Currently, this will only log something like
>>
>> error updating firewall rules: cannot execute nftables commands
>>
>> which, by itself, is pretty unhelpful. `anyhow` errors have context, so
>> show that too.
>
> How much additional lines in the log would that be?
This should not result in any extra lines, as the {:#} specifier puts
everything on one line [0]. As long as the individual messages/contexts
don't have newlines in them (which they shouldn't), of course.
[0] https://docs.rs/anyhow/latest/anyhow/struct.Error.html
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-02 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 11:23 Christoph Heiss
2025-07-02 13:42 ` Stefan Hanreich
2025-07-02 13:53 ` Christoph Heiss [this message]
2025-07-02 13:54 ` Stefan Hanreich
2025-07-02 15:53 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB1MBNIHOBYG.TZ38P2EATX0G@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.