From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: assets: update flutter app icons in iOS with proxmox icons
Date: Thu, 22 May 2025 11:33:00 +0200 [thread overview]
Message-ID: <DA2L3LU8O2RD.1E7K4LKL39R9O@noor> (raw)
In-Reply-To: <81df0520-361b-44c4-8b22-9499723e9cca@proxmox.com>
Thank you so much for the review. The changes in the `Contents.json` was
done by Xcode when i dragged and dropped the icons into the asset
catalog of Xcode. I will create another patch by removing all the
formatting and reordering changes from the `Contents.json` file.
On Wed May 21, 2025 at 1:27 PM CEST, Dominik Csapak wrote:
> while i can't test the changes for ios, the images look good,
> one question for my curiosity:
>
> what triggered the changes in the Contents.json ?
>
> AFAICS it's just reordering the properties + whitespace changes, which
> make it hard to see if there was any actual change to the content...
>
> not that I'm against it, but we should probably not unnecessarily touch these files,
> except some tooling (e.g. from flutter) autoformats these or there
> are real changes...
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-05-22 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 12:59 Shan Shaji
2025-05-21 11:27 ` Dominik Csapak
2025-05-22 9:33 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA2L3LU8O2RD.1E7K4LKL39R9O@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.