From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Alexander Abraham" <a.abraham@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/1] fix #4281: manager: Enabled logging in with Open ID
Date: Wed, 30 Apr 2025 10:32:14 +0200 [thread overview]
Message-ID: <D9JU13E2HYLK.2FY2Z8EQHC0KI@proxmox.com> (raw)
In-Reply-To: <20250429150757.130996-4-a.abraham@proxmox.com>
The commit message title should always be in present tense (handy
shortcut to remember: the commit/patch will *change* it, but it hasn't
been changed *before* the commit/patch).
Applies to the other patches in the series as well - see also our
developer documentation on that matter [0].
On Tue Apr 29, 2025 at 5:07 PM CEST, Alexander Abraham wrote:
> This commit adds an authorization flow for logging
> in a user using Open ID on the PVE web frontend in
> the mobile view.
"This commit [..]" is redundant, since the context is already clear :^)
Didn't really review the patch further, so if there's some other
important detail, it should be mentioned as well.
[0] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
> www/mobile/Login.js | 148 ++++++++++++++++++++++++++++++++++----------
> 1 file changed, 116 insertions(+), 32 deletions(-)
>
> diff --git a/www/mobile/Login.js b/www/mobile/Login.js
> index 06c8b3d4..05038036 100644
> --- a/www/mobile/Login.js
> +++ b/www/mobile/Login.js
> @@ -1,8 +1,10 @@
> +/ https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/manager6/Workspace.js;h=922e01df86718e8fc89ce5835f81d21f6d849b81;hb=HEAD
> +
Unintentional copy-paste I assume?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-30 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 15:07 [pve-devel] [PATCH manager/proxmox{_dart_api_client, _login_manager} 0/3] fix #4281 Alexander Abraham
2025-04-29 15:07 ` [pve-devel] [PATCH proxmox_dart_api_client 1/1] fix #4281: dart_api_client: Added functions for login with Open ID Alexander Abraham
2025-04-29 15:07 ` [pve-devel] [PATCH proxmox_login_manager 1/1] fix #4281: login_manager: UI changes for enabling " Alexander Abraham
2025-04-29 15:07 ` [pve-devel] [PATCH manager 1/1] fix #4281: manager: Enabled logging in " Alexander Abraham
2025-04-30 8:32 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9JU13E2HYLK.2FY2Z8EQHC0KI@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=a.abraham@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal