all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks
@ 2025-04-22 16:27 Michael Köppl
  2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 1/6] auto: add early answer file sanity check for RAID configurations Michael Köppl
                   ` (6 more replies)
  0 siblings, 7 replies; 23+ messages in thread
From: Michael Köppl @ 2025-04-22 16:27 UTC (permalink / raw)
  To: pve-devel

The goal of this series is to add additional sanity checks to the
auto-installer and the TUI and GUI installers. The following checks were
added:
* Btrfs / ZFS RAID: check if the required number of disks is available
* LVM: check if swapsize < hdsize (RFC)
* LVM: check if maxroot < hdsize/4 (RFC)
* Networking: check if IPv4 address is valid within subnet (RFC)

The disk-related checks aim to close [0], whereas the IPv4 check would
partially close [1].

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5887
[1] https://bugzilla.proxmox.com/show_bug.cgi?id=5757

The patches marked as RFC work, but I think some discussion regarding 
what we even want to check is warranted here. I added some more context
for a discussion to the individual patches.

pve-installer:

Michael Köppl (6):
  auto: add early answer file sanity check for RAID configurations
  common: use get_min_disks as single source of truth for RAID config
    checks
  close #5887: add sanity check for LVM swapsize and maxroot
  run rustfmt
  common: add more descriptive errors for invalid network configs
  common: add checks for valid IPv4 address within subnet

 Proxmox/Install.pm                            | 14 +++++
 proxinstall                                   |  5 +-
 proxmox-auto-install-assistant/src/main.rs    |  7 ++-
 proxmox-auto-installer/src/utils.rs           | 37 +++++++++--
 proxmox-auto-installer/tests/parse-answer.rs  |  8 ++-
 .../btrfs_raid_single_disk.json               |  3 +
 .../btrfs_raid_single_disk.toml               | 15 +++++
 .../lvm_maxroot_greater_than_maximum.json     |  3 +
 .../lvm_maxroot_greater_than_maximum.toml     | 16 +++++
 .../lvm_swapsize_greater_than_hdsize.json     |  3 +
 .../lvm_swapsize_greater_than_hdsize.toml     | 16 +++++
 .../zfs_raid_single_disk.json                 |  3 +
 .../zfs_raid_single_disk.toml                 | 15 +++++
 proxmox-installer-common/src/disk_checks.rs   | 38 ++++++-----
 proxmox-installer-common/src/options.rs       | 36 ++++++++++-
 proxmox-installer-common/src/utils.rs         | 63 ++++++++++++++++---
 proxmox-tui-installer/src/views/bootdisk.rs   | 14 +++--
 17 files changed, 256 insertions(+), 40 deletions(-)
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/btrfs_raid_single_disk.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/btrfs_raid_single_disk.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_maxroot_greater_than_maximum.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_maxroot_greater_than_maximum.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/zfs_raid_single_disk.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/zfs_raid_single_disk.toml


Summary over all repositories:
  17 files changed, 256 insertions(+), 40 deletions(-)

-- 
Generated by git-murpp 0.8.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2025-04-29 14:14 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-22 16:27 [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 1/6] auto: add early answer file sanity check for RAID configurations Michael Köppl
2025-04-28 11:25   ` Christoph Heiss
2025-04-28 14:31     ` Michael Köppl
2025-04-29  8:26       ` Christoph Heiss
2025-04-29  9:32         ` Michael Köppl
2025-04-29  9:40           ` Christoph Heiss
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 2/6] common: use get_min_disks as single source of truth for RAID config checks Michael Köppl
2025-04-28 11:48   ` Christoph Heiss
2025-04-28 15:36     ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [RFC PATCH pve-installer 3/6] close #5887: add sanity check for LVM swapsize and maxroot Michael Köppl
2025-04-28 12:00   ` Christoph Heiss
2025-04-29 11:30     ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 4/6] run rustfmt Michael Köppl
2025-04-23 11:56   ` Christoph Heiss
2025-04-25 12:22     ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 5/6] common: add more descriptive errors for invalid network configs Michael Köppl
2025-04-28 12:20   ` Christoph Heiss
2025-04-22 16:27 ` [pve-devel] [RFC PATCH pve-installer 6/6] closes #5757: common: add checks for valid IPv4 address within subnet Michael Köppl
2025-04-28 10:22   ` Christoph Heiss
2025-04-28 14:20     ` Michael Köppl
2025-04-28 12:25 ` [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks Christoph Heiss
2025-04-29 14:14   ` Michael Köppl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal