From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-installer 1/6] auto: add early answer file sanity check for RAID configurations
Date: Tue, 29 Apr 2025 11:40:17 +0200 [thread overview]
Message-ID: <D9J0UNUCREZR.11BVAOFS2B11X@proxmox.com> (raw)
In-Reply-To: <b0ed3d50-0204-4c66-88ed-a834fc917db6@proxmox.com>
On Tue Apr 29, 2025 at 11:32 AM CEST, Michael Köppl wrote:
> On 4/29/25 10:26, Christoph Heiss wrote:
>>>> ZFS actually lets one create RAIDZ{1,2,3} pools with 2, 3 and 4 disks,
>>>> respectively. While maybe not really _that_ practical for real-world
>>>> usecases (starting with the overhead), do we want to still allow it?
>>>
>>> I personally don't like putting too many constraints on what users can
>>> do. Even if not every setting is practical, I think the installer should
>>> allow them as long as they don't mean that the whole installation is
>>> going to crash halfway through,
>>
>> Yep, definitely. I also like to err on the side of caution and rather
>> allow more than what might be technical feasible and/or allowed - latter
>> especially w.r.t. network settings.
>>
>> I'd then just lower it to the actual allowed minimum as mentioned above,
>> doesn't hurt in any case :^)
>
> I think I'd prefer doing this in a separate series, though. Changes
> would have to be made in the installer, the UI (there's a check there as
> well when creating a ZFS pool) and, IMO, also PBS. There are checks in
> PBS as well and I don't think it's a good idea to have diverging
> behavior between PVE and PBS about what is and isn't allowed w.r.t. ZFS
> RAID setups.
I see, didn't think of all the other places where we assume this.
You can just disregard it then.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-29 9:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 16:27 [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 1/6] auto: add early answer file sanity check for RAID configurations Michael Köppl
2025-04-28 11:25 ` Christoph Heiss
2025-04-28 14:31 ` Michael Köppl
2025-04-29 8:26 ` Christoph Heiss
2025-04-29 9:32 ` Michael Köppl
2025-04-29 9:40 ` Christoph Heiss [this message]
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 2/6] common: use get_min_disks as single source of truth for RAID config checks Michael Köppl
2025-04-28 11:48 ` Christoph Heiss
2025-04-28 15:36 ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [RFC PATCH pve-installer 3/6] close #5887: add sanity check for LVM swapsize and maxroot Michael Köppl
2025-04-28 12:00 ` Christoph Heiss
2025-04-29 11:30 ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 4/6] run rustfmt Michael Köppl
2025-04-23 11:56 ` Christoph Heiss
2025-04-25 12:22 ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 5/6] common: add more descriptive errors for invalid network configs Michael Köppl
2025-04-28 12:20 ` Christoph Heiss
2025-04-22 16:27 ` [pve-devel] [RFC PATCH pve-installer 6/6] closes #5757: common: add checks for valid IPv4 address within subnet Michael Köppl
2025-04-28 10:22 ` Christoph Heiss
2025-04-28 14:20 ` Michael Köppl
2025-04-28 12:25 ` [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks Christoph Heiss
2025-04-29 14:14 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9J0UNUCREZR.11BVAOFS2B11X@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal