Re: [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks

["Christoph Heiss" <c.heiss@proxmox.com>]

Thanks for tackling this.

Reviewed the series and left some comments on the individual patches,
mostly some thoughts and nits.

Also tested `proxmox-auto-install-assistant validate-answer` for the new
cases, as well as the early RAID check in the GUI and the auto
installer.

On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
> The goal of this series is to add additional sanity checks to the
> auto-installer and the TUI and GUI installers. The following checks were
> added:
> * Btrfs / ZFS RAID: check if the required number of disks is available
> * LVM: check if swapsize < hdsize (RFC)
> * LVM: check if maxroot < hdsize/4 (RFC)
> * Networking: check if IPv4 address is valid within subnet (RFC)
>
> The disk-related checks aim to close [0], whereas the IPv4 check would
> partially close [1].
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5887
> [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5757
>
> The patches marked as RFC work, but I think some discussion regarding
> what we even want to check is warranted here. I added some more context
> for a discussion to the individual patches.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel