From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Stefan Hanreich" <s.hanreich@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v2 1/1] ve-config: move types to proxmox-network-types
Date: Wed, 02 Apr 2025 10:39:03 +0200 [thread overview]
Message-ID: <D8W0N2I2SFYQ.N3X4NZYBWP0J@proxmox.com> (raw)
In-Reply-To: <20250401133616.331046-3-s.hanreich@proxmox.com>
Just a quick note:
On Tue Apr 1, 2025 at 3:36 PM CEST, Stefan Hanreich wrote:
[..]
> diff --git a/proxmox-ve-config/src/firewall/types/address.rs b/proxmox-ve-config/src/firewall/types/address.rs
> index 9b73d3d..548b813 100644
> --- a/proxmox-ve-config/src/firewall/types/address.rs
> +++ b/proxmox-ve-config/src/firewall/types/address.rs
[..]
> - assert_eq!(
> - [Ipv6Cidr::new(
> - [0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF],
> - 128
> - )
> - .unwrap(),],
> - range.to_cidrs().as_slice()
> - );
> - }
> }
> +
nit: new blank line at eof, guess just an accidental typo? :^)
Came across it while applying the patch for a quick compile-test.
Applying: ve-config: move types to proxmox-network-types
.git/rebase-apply/patch:1548: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Just wanted to mention, can easily be fixed up during applying as well.
Definitely not worth a resend in any case, IMO.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-02 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 13:36 [pve-devel] [PATCH proxmox v2 1/2] network-types: initial commit Stefan Hanreich
2025-04-01 13:36 ` [pve-devel] [PATCH proxmox v2 2/2] network-types: add hostname type Stefan Hanreich
2025-04-01 13:36 ` [pve-devel] [PATCH proxmox-ve-rs v2 1/1] ve-config: move types to proxmox-network-types Stefan Hanreich
2025-04-02 8:39 ` Christoph Heiss [this message]
2025-04-01 13:36 ` [pve-devel] [PATCH proxmox-firewall v2 1/1] firewall: nftables: migrate " Stefan Hanreich
2025-04-01 14:53 ` [pve-devel] superseded: [PATCH proxmox v2 1/2] network-types: initial commit Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8W0N2I2SFYQ.N3X4NZYBWP0J@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.