From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Yew framework devel list at Proxmox" <yew-devel@lists.proxmox.com>
Subject: Re: [yew-devel] [PATCH pywt] catalog_loader: fix url for translation files
Date: Wed, 22 Jan 2025 13:59:23 +0100 [thread overview]
Message-ID: <D78MC95D2PHE.MOB9DVOQPFT5@proxmox.com> (raw)
In-Reply-To: <20250122121349.239939-1-m.sandoval@proxmox.com>
On Wed Jan 22, 2025 at 1:13 PM CET, Maximiliano Sandoval wrote:
> As per proxmox-datacenter-api.rs:
> ```rust
> ("locale", "/usr/share/pdm-i18n"),
> ```
> the translations are at /locale/catalog-{lang}.mo
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/widget/catalog_loader.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/widget/catalog_loader.rs b/src/widget/catalog_loader.rs
> index 21437991..c3732d49 100644
> --- a/src/widget/catalog_loader.rs
> +++ b/src/widget/catalog_loader.rs
> @@ -49,7 +49,7 @@ impl CatalogLoader {
> if let Some(url_builder) = &self.url_builder {
> url_builder.apply(&lang)
> } else {
> - format!("catalog-{}.mo", lang)
> + format!("locale/catalog-{lang}.mo")
> }
> }
> }
this re-defines the fallback here. i'd rather you give this catalog
loader an `url_builder` as that is the already implemented way of
adapting the location of catalogs. if you change that here, that is a
breaking change for users of this crate, so that would need more
considerations imo.
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
next prev parent reply other threads:[~2025-01-22 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 12:13 Maximiliano Sandoval
2025-01-22 12:59 ` Shannon Sterz [this message]
2025-01-22 14:53 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D78MC95D2PHE.MOB9DVOQPFT5@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.