Re: [pbs-devel] [PATCH proxmox v3 1/4] sendmail: add sendmail crate

["Shannon Sterz" <s.sterz@proxmox.com>]

On Mon Dec 2, 2024 at 3:33 PM CET, Lukas Wagner wrote:
>
>
> On  2024-12-02 15:22, Shannon Sterz wrote:
> > On Mon Dec 2, 2024 at 3:16 PM CET, Shannon Sterz wrote:
> >> add the `proxmox-sendmail` crate that makes it easier to send mails via
> >> the `sendmail` utility. features include:
> >>
> >> - multipart/alternative support for html+plain text mails
> >> - multipart/mixed support for mails with attachments
> >> - automatic nesting of multipart/alternative and multipart/mixed parts
> >> - masks multiple receivers by default, can be disabled
> >> - encoding Subject, To, From, and attachment file names correctly
> >> - adding an `Auto-Submitted` header to avoid triggering automated mails
> >>
> >> also includes several tests to ensure that mails are formatted
> >> correctly. debian packaging is also provided.
> >>
> >> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> >
> > forgot to add this in the v2 already, but since that is now obsolete,
> > but unless Lukas objects this should probably include:
> >
> > Tested-by: Lukas Wagner <l.wagner@proxmox.com>
> > Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
> >
> > just thought i'd quickly mention this before it gets lost
> >
>
> Changes look good, so no objection from me.
> Only tested v1 and v2, but since this has some serious test coverage
> which I assume you have run before submitting v3, I think
> the T-b is also okay :)

i did and the changes should be contained to proxmox-sendmail in v3 so
hopefully that is all fine. thanks for the quick response time!



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel