From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys
Date: Fri, 29 Nov 2024 11:55:35 +0100 [thread overview]
Message-ID: <D5YLW1K5IJVM.2M0OPS2TRG2AR@proxmox.com> (raw)
In-Reply-To: <6a0f2b99-eab2-49f1-ac04-b01cbb041b03@proxmox.com>
On Tue Nov 26, 2024 at 11:21 AM CET, Thomas Lamprecht wrote:
> Am 26.11.24 um 10:27 schrieb Shannon Sterz:
> > actually i needed to adapt this to add support for attachments, which
> > require reworking the multipart logic a bit too. i can factor that out
> > into it's own `proxmox-sendmail` crate or similar and make
> > `proxmox-notify`'s sendmail endpoint use that too. if that's desired, i
> > can send patches for that too.
>
> Yeah, that might be nice. While this probably won't have a very high reusability,
> it can be carved out nicely in a standalone crate, and it should also not be a
> (fast) moving target, so fine to have as separate crate IMO.
finally managed to send patches for this, see here [1].
[1]: https://lore.proxmox.com/pbs-devel/20241129105321.143877-1-s.sterz@proxmox.com/
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-29 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 12:31 [pve-devel] " Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 2/6] sys: mark email fn's as deprecated Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 3/6] notify: sendmail: make mailfrom and author non-optional Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 4/6] notify: move mail formatting to separate function Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 5/6] notify: sendmail: always send multi-part message Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 6/6] notify: sendmail: code style improvements Lukas Wagner
2024-07-12 8:56 ` [pve-devel] partially-applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys Wolfgang Bumiller
2024-11-25 10:22 ` [pve-devel] " Lukas Wagner
2024-11-25 22:19 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-26 9:27 ` Shannon Sterz
2024-11-26 10:21 ` Thomas Lamprecht
2024-11-29 10:55 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5YLW1K5IJVM.2M0OPS2TRG2AR@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal