Re: [pbs-devel] [PATCH vma-to-pbs v5 4/4] log device upload progress as a percentage

["Shannon Sterz" <s.sterz@proxmox.com>]

comments in-line:

On Mon Nov 11, 2024 at 2:08 PM CET, Filip Schauer wrote:
> Log the upload progress of a device as a percentage with log level info
> every 1000 chunks.
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>  src/vma2pbs.rs | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/vma2pbs.rs b/src/vma2pbs.rs
> index 0517251..f469053 100644
> --- a/src/vma2pbs.rs
> +++ b/src/vma2pbs.rs
> @@ -6,6 +6,8 @@ use std::fs::File;
>  use std::io::{stdin, BufRead, BufReader, Read};
>  use std::process::{Command, Stdio};
>  use std::ptr;
> +use std::sync::atomic::{AtomicU64, Ordering};
> +use std::sync::Arc;
>  use std::time::SystemTime;
>
>  use anyhow::{anyhow, bail, Error};
> @@ -234,6 +236,8 @@ where
>          non_zero_mask: u64,
>      }
>
> +    let chunk_stats = Arc::new([const { AtomicU64::new(0) }; VMA_MAX_DEVICES]);
> +
>      let images_chunks: RefCell<HashMap<u8, HashMap<u64, ImageChunk>>> =
>          RefCell::new(HashMap::new());
>
> @@ -284,6 +288,11 @@ where
>                  pbs_chunk_offset,
>                  pbs_chunk_offset + pbs_chunk_size,
>              );
> +            let chunk_stat = chunk_stats[dev_id as usize].fetch_add(1, Ordering::SeqCst);
> +            if (chunk_stat % 1000) == 0 {
> +                let percentage = 100 * PROXMOX_BACKUP_DEFAULT_CHUNK_SIZE * chunk_stat / device_size;
> +                log::info!("\tUploading dev_id: {} ({}%)", dev_id, percentage);

nit: format string

> +            }
>
>              let mut pbs_err: *mut c_char = ptr::null_mut();
>

Other than the nits across the four patches, consider this series:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel