all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Alexander Zeidler" <a.zeidler@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command
Date: Fri, 06 Sep 2024 14:16:00 +0200	[thread overview]
Message-ID: <D3Z6ZUUC8FS7.1DA52U49ZTQIZ@proxmox.com> (raw)
In-Reply-To: <20240906104019.40450-1-f.ebner@proxmox.com>

On Fri Sep 6, 2024 at 12:40 PM CEST, Fiona Ebner wrote:
> (DPkg::Pre-Invoke is also too late). Since this is just an additional
> safety warning to guide new users, it should still be good enough.

> +  if ($line && $line =~ m/^CommandLine::AsString=apt(-get)?%20upgrade$/) {
> +    $log->("!! WARNING !!\n");
> +    $log->("Using 'upgrade' can violate packaging assumptions made by Proxmox VE. Use 'dist-upgrade' instead.\n");
> +    $log->("\n");

As "an additional safety warning to guide new users", we may want to
rephrase this line:
> +    $log->("Press enter to continue, or C^c to abort.\n");
to something like:
"Press CTRL+C to abort, or ENTER to continue anyway."


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-09-06 12:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 10:40 Fiona Ebner
2024-09-06 10:42 ` Fiona Ebner
2024-09-06 11:01 ` Dominik Csapak
2024-09-06 16:54   ` Thomas Lamprecht
2024-09-06 12:16 ` Alexander Zeidler [this message]
2024-09-06 16:56   ` Thomas Lamprecht
2024-09-06 16:58 ` Thomas Lamprecht
2024-09-09  7:48   ` Fabian Grünbichler
2024-09-09  7:52     ` Fiona Ebner
2024-09-09  7:57       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D3Z6ZUUC8FS7.1DA52U49ZTQIZ@proxmox.com \
    --to=a.zeidler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal