From: "Max Carrara" <m.carrara@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI
Date: Thu, 06 Jun 2024 10:06:52 +0200 [thread overview]
Message-ID: <D1SS2ZNCW9Y6.LHIRET7YTUL2@proxmox.com> (raw)
In-Reply-To: <f0582db3-64f2-4ddb-80c4-78df1085ee4c@proxmox.com>
On Wed Jun 5, 2024 at 4:48 PM CEST, Lukas Wagner wrote:
>
>
> On 2024-04-30 17:28, Max Carrara wrote:
> > Ceph Build Commit in UI - Version 1
> > ===================================
> >
> > This series adds Ceph's build commit to the UI and lets the user know if
> > a service is running an outdated build and therefore ought to be
> > restarted.
> >
> > The build commit is now displayed next to the version for all Ceph
> > services like so:
> >
> > 18.2.2 (abcd1234)
> >
> > Should a service run an outdated build, the new build commit is also
> > displayed:
> >
> > 18.2.2 (abcd1234 -> 5678fedc)
> >
> > (Icons are omitted here).
> >
> > See the individual patches for more in-depth information.
> >
> > Additionally, some of the code was also cleaned up and refactored a
> > little along the way.
> >
> > I'm not 100% sure if the design I've opted for here is the best, so it
> > would be great to get some opinions on this. The OSD tree/list view
> > especially can get a little noisy if there are a lot of outdated OSDs
> > running.
> >
>
> Neat, gave this a quick test and this seems to do what you describe in the cover letter.
>
> Some comments:
> - The 'outdated OSD' view in the top-level status widget uses a different icon to
> signal an outdated OSD than the version column in the OSD tree view - maybe it would make sense
> to use the same icon here?
> - The 'Detail' view for OSDs could also show the commit hash, right now it only shows e.g. 18.2.2 (reef)
>
>
> With the nits from the review fixed:
>
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Thanks a lot for the review and giving this a spin! I'll see if I can
send in a v2 soon. If noone else has any objections, I'll attach your
T-b and R-b tags in the new series.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-06-06 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:28 Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 1/8] ceph: tools: refactor installation check as guard clause Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 2/8] ceph: tools: update Ceph version regex Max Carrara
2024-06-05 14:48 ` Lukas Wagner
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 3/8] ceph: services: remove old cluster broadcast Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 4/8] ceph: services: refactor version existence check as guard clause Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 5/8] utils: align regex of parse_ceph_version with Perl equivalent Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 6/8] ui: ceph: services: parse and display build commit Max Carrara
2024-06-05 14:48 ` Lukas Wagner
2024-06-06 8:04 ` Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 7/8] api: ceph: add build commit of host to Ceph osd index endpoint data Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 8/8] ui: ceph: osd: rework rendering of version field & show build commit Max Carrara
2024-06-05 14:48 ` Lukas Wagner
2024-06-06 8:04 ` Max Carrara
2024-06-05 9:16 ` [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI Max Carrara
2024-06-05 14:48 ` Lukas Wagner
2024-06-06 8:06 ` Max Carrara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1SS2ZNCW9Y6.LHIRET7YTUL2@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal