From: "Max Carrara" <m.carrara@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 0/7] use email regex from HTML spec for validation
Date: Mon, 03 Jun 2024 10:20:04 +0200 [thread overview]
Message-ID: <D1Q8HGIPRB3E.1Y7V3RI109Z8X@proxmox.com> (raw)
In-Reply-To: <20240528081359.832986-1-c.heiss@proxmox.com>
On Tue May 28, 2024 at 10:13 AM CEST, Christoph Heiss wrote:
> This uses the regex for <input type="email" /> elements as defined in
> the HTML spec to validate emails in the installer. That regex should be
> a lot more robust than our current on and cover basically all cases of
> email addresses that might be encountered in the while.
>
> Also, patch #6 adds validation for the auto-installer `global.mailto`
> option too, while at it.
>
> Patches #1 through #4 are just small cleanups/fixes and may be applied
> independently.
>
> [0] https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address
The changes in this series are rather straightforward; there's nothing
extraordinary going on. LGTM.
Reviewed-by: Max Carrara <m.carrara@proxmox.com>
>
> Christoph Heiss (7):
> cargo: convert `anyhow` to workspace dependency
> tui: fix new clippy lint
> auto-installer: drop some unneeded `pub` modifiers
> auto-installer: print full anyhow message on failure
> tui: use email regex from HTML specification for validation
> auto-installer: validate `global.mailto` answer option
> proxinstall: use email regex from HTML specification for validation
>
> Cargo.toml | 2 ++
> Proxmox/Makefile | 1 +
> Proxmox/Sys.pm | 9 ++++++
> proxinstall | 3 +-
> proxmox-auto-install-assistant/Cargo.toml | 2 +-
> proxmox-auto-installer/Cargo.toml | 2 +-
> .../src/bin/proxmox-auto-installer.rs | 2 +-
> proxmox-auto-installer/src/utils.rs | 17 ++++++-----
> proxmox-chroot/Cargo.toml | 2 +-
> proxmox-fetch-answer/Cargo.toml | 2 +-
> proxmox-installer-common/Cargo.toml | 1 +
> proxmox-installer-common/src/options.rs | 29 ++++++++++++++++++-
> proxmox-tui-installer/Cargo.toml | 1 -
> proxmox-tui-installer/src/main.rs | 22 +++++---------
> 14 files changed, 65 insertions(+), 30 deletions(-)
> create mode 100644 Proxmox/Sys.pm
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-06-03 8:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 8:13 Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 1/7] cargo: convert `anyhow` to workspace dependency Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 2/7] tui: fix new clippy lint Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 3/7] auto-installer: drop some unneeded `pub` modifiers Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 4/7] auto-installer: print full anyhow message on failure Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 5/7] tui: use email regex from HTML specification for validation Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 6/7] auto-installer: validate `global.mailto` answer option Christoph Heiss
2024-05-28 8:13 ` [pve-devel] [PATCH installer 7/7] proxinstall: use email regex from HTML specification for validation Christoph Heiss
2024-06-03 8:20 ` Max Carrara [this message]
2024-06-28 8:16 ` [pve-devel] [PATCH installer 0/7] use email regex from HTML spec " Christoph Heiss
2024-10-02 12:32 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1Q8HGIPRB3E.1Y7V3RI109Z8X@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal