Re: [pbs-devel] [PATCH proxmox-backup 1/2] config: add default datastore creation function

["Gabriel Goller" <g.goller@proxmox.com>]

On Mon May 13, 2024 at 10:52 AM CEST, Christian Ebner wrote:
> On 5/3/24 16:29, Gabriel Goller wrote:
> > Add a function to create a default datastore. This datastore will have a
> > default prune-job with a daily schedule and a gc-job with a daily
> > schedule as well.
> > 
>
> Tested this and found that while the default prune and 
> garbage-collection jobs are created when creating the datastore via the 
> WebUI or as part of a disk create transaction, this is not true if done 
> via the CLI or API for the datastore create itself, by e.g. 
> `proxmox-backup-manager datastore create <name> <path>`.

This was intended. I talked about this with Stefan Lendl as well when he
wrote the patches.

I think the idea was to create the default jobs when creating a
datastore through the ui (thus my patches above), but create a bare
datastore (without any jobs) when using the cli.

Obviously this is not so consistent.

> Also, this default behavior should be documented.

Absolutely.

>
> So similar to what Fabian already commented to patches from my side:
> https://lists.proxmox.com/pipermail/pbs-devel/2023-November/007361.html

Yes, fabian also mentioned the crucial point: when creating a datastore
through the ui, you have the option to *not* create the default prune/gc
jobs.

In my patch series above you cannot do that because it's done on the
api side.

IMO I would discard my series here... 

I don't even know if adding a button to the ui 'create default jobs' or
something like that would even be beneficial or just clutter the
interface.



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel