From: "Max Carrara" <m.carrara@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5422: ui: make columns in gcview sortable
Date: Tue, 07 May 2024 16:11:24 +0200 [thread overview]
Message-ID: <D13H1QWRE7RU.3RVI7I3J2BJOO@proxmox.com> (raw)
In-Reply-To: <20240507081304.29656-1-g.goller@proxmox.com>
On Tue May 7, 2024 at 10:13 AM CEST, Gabriel Goller wrote:
> These columns were not sortable for some reason. Tested it as well and
> the sorting seems to work fine.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
LGTM
Reviewed-by: Max Carrara <m.carrara@proxmox.com>
Tested-by: Max Carrara <m.carrara@proxmox.com>
> ---
> www/config/GCView.js | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/www/config/GCView.js b/www/config/GCView.js
> index bcea72a5..1c9288e4 100644
> --- a/www/config/GCView.js
> +++ b/www/config/GCView.js
> @@ -164,7 +164,7 @@ Ext.define('PBS.config.GCJobView', {
> {
> header: gettext('Schedule'),
> dataIndex: 'schedule',
> - sortable: false,
> + sortable: true,
> hideable: false,
> renderer: (value) => value ? value : Proxmox.Utils.NoneText,
> minWidth: 85,
> @@ -182,7 +182,7 @@ Ext.define('PBS.config.GCJobView', {
> text: gettext('Duration'),
> dataIndex: 'duration',
> renderer: Proxmox.Utils.render_duration,
> - sortable: false,
> + sortable: true,
> minWidth: 80,
> flex: 1,
> },
> @@ -207,7 +207,7 @@ Ext.define('PBS.config.GCJobView', {
> dataIndex: 'removed-bytes',
> renderer: (value, meta, record) => record.data.upid !== null
> ? Proxmox.Utils.format_size(value, true) : "-",
> - sortable: false,
> + sortable: true,
> minWidth: 85,
> flex: 1,
> },
> @@ -216,7 +216,7 @@ Ext.define('PBS.config.GCJobView', {
> dataIndex: 'pending-bytes',
> renderer: (value, meta, record) => record.data.upid !== null
> ? Proxmox.Utils.format_size(value, true) : "-",
> - sortable: false,
> + sortable: true,
> minWidth: 80,
> flex: 3,
> },
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-05-07 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 8:13 Gabriel Goller
2024-05-07 14:11 ` Max Carrara [this message]
2024-05-15 12:34 ` Thomas Lamprecht
2024-05-16 9:05 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D13H1QWRE7RU.3RVI7I3J2BJOO@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.