From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox v3 1/2] metrics: encode influxdb org and bucket parameters
Date: Tue, 30 Apr 2024 12:11:44 +0200 [thread overview]
Message-ID: <D0XDKFKVC34G.28I8J36MOB0FQ@proxmox.com> (raw)
In-Reply-To: <7685e590-6730-4450-9cc2-a75cbc9aed61@proxmox.com>
On Fri Apr 26, 2024 at 5:52 PM CEST, Thomas Lamprecht wrote:
> Am 26/04/2024 um 16:02 schrieb Gabriel Goller:
> > In order to remove the current limitations on the bucket and
> > organization names, we need to make sure that they are transmitted
> > correctly. In order to do this, we encode them using the url crate.
> >
> > This way we support organization/bucket names that include slashes,
> > whitespaces, etc.
> >
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> > proxmox-metrics/Cargo.toml | 1 +
> > proxmox-metrics/src/influxdb/http.rs | 7 ++++++-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> >
>
> applied, thanks!
>
> Having some tests here might be nice though. E.g., moving the URI assembly
> into a separate method and having either a test module or doc-tests to
> ensure that some common and odd cases, e.g. those requiring encoding, are
> handled correctly.
Sent a follow-up to the list!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-30 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 14:02 [pbs-devel] [PATCH proxmox{, -backup} v3 0/2] Remove influxdb bucket name restrictions Gabriel Goller
2024-04-26 14:02 ` [pbs-devel] [PATCH proxmox v3 1/2] metrics: encode influxdb org and bucket parameters Gabriel Goller
2024-04-26 15:52 ` [pbs-devel] applied: " Thomas Lamprecht
2024-04-30 10:11 ` Gabriel Goller [this message]
2024-04-26 14:02 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] api-types: remove influxdb bucket name restrictions Gabriel Goller
2024-04-26 15:57 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0XDKFKVC34G.28I8J36MOB0FQ@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.