Re: [pbs-devel] [PATCH proxmox-backup 1/2] docs: document notification-mode and merge old notification section

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Apr 25, 2024 at 2:41 PM CEST, Gabriel Goller wrote:
> > +If ``notification-mode`` is set to ``legacy-sendmail``,  Proxmox Backup Server
> > +will send notification emails via the system's ``sendmail`` command to the email
> > +address configured for the user set in the ``notify-user`` option
> > +(falling back to ``root@pam`` if not set)
>
> A period is missing in the last sentence above.

Fixed, thanks!

>
> > +
> > +For datastores, you can also change the level of notification received per task
>
> 'notification' -> 'notifications'
>
Fixed as well.

> > +type via the ``notify`` option.
> > +
> > +* Always: send a notification for any scheduled task, independent of the
> > +  outcome
> > +
> > +* Errors: send a notification for any scheduled task that results in an error
> > +
> > +* Never: do not send any notification at all
> > +
> > +The ``notify-user`` and ``notify`` options are ignored if ``notification-mode``
> > +is set to ``notification-system``.
> > diff --git a/docs/storage.rst b/docs/storage.rst
> > index 4444c423..f1e15d52 100644
> > --- a/docs/storage.rst
> > +++ b/docs/storage.rst
> > @@ -314,7 +314,7 @@ Options
> >  
> >  There are a few per-datastore options:
> >  
> > -* :ref:`Notifications <maintenance_notification>`
> > +* :ref:`Notification mode and legacy notification settings <notification_mode>`
> >  * :ref:`Maintenance Mode <maintenance_mode>`
> >  * Verification of incoming backups
> >  
> > @@ -419,7 +419,7 @@ remote-source to avoid that an attacker that took over the source can cause
> >  deletions of backups on the target hosts.
> >  If the source-host became victim of a ransomware attack, there is a good chance
> >  that sync jobs will fail, triggering an :ref:`error notification
> > -<maintenance_notification>`.
> > +<Notification Events>`.
> >  
> >  It is also possible to create :ref:`tape backups <tape_backup>` as a second
> >  storage medium. This way, you get an additional copy of your data on a
>
> Otherwise this looks good!
>
> Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
>

Thanks, I'll send a v2 swiftly.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel