Re: [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow`

From: "Stefan Sterz" <s.sterz@proxmox.com>
To: "Stefan Sterz" <s.sterz@proxmox.com>, <pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow`
Date: Thu, 25 Apr 2024 10:37:10 +0200	[thread overview]
Message-ID: <D0T2FAWKDPSX.YSZ83B6DKC62@proxmox.com> (raw)
In-Reply-To: <20240405141257.165513-1-s.sterz@proxmox.com>

On Fri Apr 5, 2024 at 4:12 PM CEST, Stefan Sterz wrote:
> since the api rejects unknown parameters, deleteEmpty needs to be
> unset here, because the endpoint for creating backups does not support
> deleting parameters. otherwise a user will get a fairly cryptic error
> message in the gui.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  www/tape/window/TapeBackup.js | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/www/tape/window/TapeBackup.js b/www/tape/window/TapeBackup.js
> index 941b6b83..4c027ab0 100644
> --- a/www/tape/window/TapeBackup.js
> +++ b/www/tape/window/TapeBackup.js
> @@ -39,6 +39,7 @@ Ext.define('PBS.TapeManagement.TapeBackupWindow', {
>  		    fieldLabel: gettext('Max Depth'),
>  		    disabled: true,
>  		    name: 'max-depth',
> +		    deleteEmpty: false,
>  		},
>  		{
>  		    xtype: 'pbsMediaPoolSelector',

ping, this is a fairly minor improvement that fixes the one of tape
backup ui


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel