Re: [pbs-devel] [PATCH proxmox-backup] api-types: remove influxdb name restrictions

["Gabriel Goller" <g.goller@proxmox.com>]

On Mon Apr 22, 2024 at 9:26 AM CEST, Thomas Lamprecht wrote:
> Am 22/04/2024 um 09:20 schrieb Gabriel Goller:
> > On Sun Apr 21, 2024 at 1:28 PM CEST, Thomas Lamprecht wrote:
> >> for the subject please do s/name/bucket name/ as otherwise one might think
> >> this is about the ID of an InfluxDB metric server.
> > 
> > Will do.
> > 
> >> Am 19/04/2024 um 15:18 schrieb Gabriel Goller:
> >>> Remove the regex for influxdb organizations and buckets. Influxdb does
> >>> not place any constraints on these names and allows all characters. This
> >>> allows influxdb organization names with slashes.
> >>>
> >>> Also remove a duplicate comment and add some missing ones.
> >>
> >>
> >> did you run into this or some user (forum link, bug report)?
> > 
> > From a forum thread here (will also include this in the next patch): 
> > https://forum.proxmox.com/threads/influx-db-organization-doesnt-allow-slash.145402/
> > 
> >> What about Proxmox VE, that also has a InfluxDB 
> > 
> > In Proxmox VE there are no restrictions to bucket/organization names.
> > 
>
> OK, it would be nice to mention that here, because having the same schema
> and behavior across products is a merit in itself.

Thanks for the review!
Submitted a v2.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel