Re: [pbs-devel] [PATCH v7 vma-to-pbs 0/9] Implement vma-to-pbs tool

["Max Carrara" <m.carrara@proxmox.com>]

On Tue Apr 9, 2024 at 2:14 PM CEST, Filip Schauer wrote:
> Implement a tool to import VMA files into a Proxmox Backup Server
>
> Example usage:
>
> zstd -d --stdout vzdump.vma.zst | vma-to-pbs \
>     --repository <auth_id@host:port:datastore> \
>     --vmid 123 \
>     --password-file pbs_password
>
> Changes since v6:
> * Move bail! in VmaReader::restore to the commit it was introduced in
> * Move the use of anyhow::Context for fingerprint argument matching to
>   the commit it was introduced in
> * Use proxmox_time::epoch_to_rfc3339 for formatting backup_time
> * Refactor elapsed time calculation for better readability
> * Bump proxmox-backup-qemu in order to get access to ProxmoxBackupHandle
> * use anyhow::format_err
> * Move introduction of handle_pbs_error to the commit that introduced
>   vma2pbs.
> * Use anyhow::Error with std::result::Result instead of anyhow::Result

 I've read all the patches and also tested the CLI again with a couple
 .vma.zst files. Everything seems to work flawlessly. This came a long
 way - very nice job! :)

 I know this series got applied already, but FWIW:

 Reviewed-by: Max Carrara <m.carrara@proxmox.com>
 Tested-by: Max Carrara <m.carrara@proxmox.com>