From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/3] docs: clarify and expand the description of the garbage collection
Date: Fri, 05 Apr 2024 12:58:18 +0200 [thread overview]
Message-ID: <D0C4WGS75UQ7.1JYCRM14RD3ZL@proxmox.com> (raw)
In-Reply-To: <20240402133627.235028-1-h.duerr@proxmox.com>
Apart from the small nits that I mentioned in the first reply this looks
really good. Especially the timing example looks great!
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>
prev parent reply other threads:[~2024-04-05 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 13:36 Hannes Duerr
2024-04-02 13:36 ` [pbs-devel] [PATCH proxmox-backup 1/3] docs: centralise and update garbage collection description Hannes Duerr
2024-04-05 10:49 ` Gabriel Goller
2024-04-02 13:36 ` [pbs-devel] [PATCH proxmox-backup 2/3] docs: add custom class for svgs Hannes Duerr
2024-04-02 13:36 ` [pbs-devel] [PATCH proxmox-backup 3/3] docs: add garbage collection timing example Hannes Duerr
2024-04-05 10:58 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0C4WGS75UQ7.1JYCRM14RD3ZL@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.