From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] fix #5188: gui: add copy to clipboard on snapshots
Date: Thu, 14 Mar 2024 10:10:58 +0100 [thread overview]
Message-ID: <CZTCUB1LXTKH.24YIFIGOXIMX3@proxmox.com> (raw)
In-Reply-To: <f463e77b-2285-4037-8567-efac001b33e7@proxmox.com>
On Thu Mar 14, 2024 at 9:01 AM CET, Dominik Csapak wrote:
> same comment as the previous patch, some note about why async is
> ok would be nice
>
> one high level comment:
>
> i'd probably rename the button from 'copy' to something like 'copy name to clipboard'
>
> otherwise it can be confusing as to what the button does, since 'copy' could
> also mean duplicate the snapshot ;)
I agree, will rename it in v2.
> rest of the patch LGTM
Thanks for the review!
next prev parent reply other threads:[~2024-03-14 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 16:17 [pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls Gabriel Goller
2024-03-13 16:17 ` [pbs-devel] [PATCH proxmox-backup 2/2] fix #5188: gui: add copy to clipboard on snapshots Gabriel Goller
2024-03-14 8:01 ` Dominik Csapak
2024-03-14 9:10 ` Gabriel Goller [this message]
2024-03-14 7:59 ` [pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls Dominik Csapak
2024-03-14 9:08 ` Gabriel Goller
2024-03-14 9:13 ` Dominik Csapak
2024-03-14 9:21 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZTCUB1LXTKH.24YIFIGOXIMX3@proxmox.com \
--to=g.goller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal