[pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[Hannes Laimer]

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---

came up in enterprise support, and I don't think there is a reason to
not have it in the UI, while having it in the API

 www/manager6/storage/DirEdit.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 3e2025fc..52e7134b 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
 	    },
 	];
 
+	me.advancedColumn2 = [
+	    {
+		xtype: 'proxmoxcheckbox',
+		name: 'is_mountpoint',
+		uncheckedValue: 0,
+		fieldLabel: gettext('Mountpoint'),
+		autoEl: {
+		    tag: 'div',
+		    'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),
+		},
+	    },
+	];
 	me.callParent();
     },
 });
-- 
2.39.2

Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[Aaron Lauterer]

Overall good idea :)

On 2/23/24 12:45, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> 
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
> 
>   www/manager6/storage/DirEdit.js | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> index 3e2025fc..52e7134b 100644
> --- a/www/manager6/storage/DirEdit.js
> +++ b/www/manager6/storage/DirEdit.js
> @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
>   	    },
>   	];
>   
> +	me.advancedColumn2 = [
> +	    {
> +		xtype: 'proxmoxcheckbox',
> +		name: 'is_mountpoint',
> +		uncheckedValue: 0,
> +		fieldLabel: gettext('Mountpoint'),
> +		autoEl: {
> +		    tag: 'div',
> +		    'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),

Maybe phrase the tooltip like this?

Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.


As there are also use-cases where something local is mounted outside of the PVE tooling where the is_mountpoint option is useful.

> +		},
> +	    },
> +	];
>   	me.callParent();
>       },
>   });

Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[Hannes Laimer]

On Fri Feb 23, 2024 at 12:51 PM CET, Aaron Lauterer wrote:
> Overall good idea :)
>
> On 2/23/24 12:45, Hannes Laimer wrote:
> > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> > ---
> > 
> > came up in enterprise support, and I don't think there is a reason to
> > not have it in the UI, while having it in the API
> > 
> >   www/manager6/storage/DirEdit.js | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> > 
> > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> > index 3e2025fc..52e7134b 100644
> > --- a/www/manager6/storage/DirEdit.js
> > +++ b/www/manager6/storage/DirEdit.js
> > @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
> >   	    },
> >   	];
> >   
> > +	me.advancedColumn2 = [
> > +	    {
> > +		xtype: 'proxmoxcheckbox',
> > +		name: 'is_mountpoint',
> > +		uncheckedValue: 0,
> > +		fieldLabel: gettext('Mountpoint'),
> > +		autoEl: {
> > +		    tag: 'div',
> > +		    'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),
>
> Maybe phrase the tooltip like this?
>
> Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.
sure, I'll send a v2
>
>
> As there are also use-cases where something local is mounted outside of the PVE tooling where the is_mountpoint option is useful.
>
> > +		},
> > +	    },
> > +	];
> >   	me.callParent();
> >       },
> >   });