all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Skinner <thomas@atskinner.net>
To: Daniel Kral <d.kral@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 1/1] add docs for maintenance mode buttons in UI
Date: Tue, 26 Aug 2025 11:05:01 -0500	[thread overview]
Message-ID: <CALn9RMe1E=h-4tiz4_M5nsFZGHMYDk_Bh3ug1J6DOXsvP2zL5g@mail.gmail.com> (raw)
In-Reply-To: <DCC9H0H1GJPX.WFZK39TCRP6Z@proxmox.com>

On Tue, Aug 26, 2025 at 4:44 AM Daniel Kral <d.kral@proxmox.com> wrote:
>
> On Mon Aug 25, 2025 at 6:11 AM CEST, Thomas Skinner wrote:
> > Signed-off-by: Thomas Skinner <thomas@atskinner.net>
> > ---
> >  ha-manager.adoc | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >
> > diff --git a/ha-manager.adoc b/ha-manager.adoc
> > index f16cfbb..b41a73b 100644
> > --- a/ha-manager.adoc
> > +++ b/ha-manager.adoc
> > @@ -1115,7 +1115,19 @@ maintenance mode is disabled and the node is back online.
> >  Currently you can enabled or disable the maintenance mode using the ha-manager
> >  CLI tool.
> >
> > +Maintenance mode can be enabled or disabled using the buttons on the HA pane in
> > +the {pve} web UI or by using the ha-manager CLI tool.
>
> s/pane/panel/?
>
> I understand that pane might be more correct here, but I'd guess that
> users are more familiar with 'panel' here.

Yep, that makes sense to me. Will fix up for a v2 patch.

> Also, I think it would be nicer to integrate that into the former
> sentence, for example:
>
> Currently you can enabled or disable the maintenance mode in the HA
> status panel in the web UI or using the ha-manager CLI tool.

I actually meant for that one to be gone and replaced with the added
sentence instead. I must've missed the removal on my local branch
patch application. Is the replacement sentence okay or should it be
removed and the existing sentence updated?

> > +
> >  .Enabling maintenance mode for a node
> > +
> > +_Using the web UI_
> > +
> > +Navigate to the Datacenter view, then select HA from the menu to show the HA
> > +Status pane. Select the lrm node that you want to enable maintenance mode for,
> > +then click the Enable Maintenance Mode button from the toolbar.
> > +
> > +_Using the CLI_
> > +
> >  ----
> >  # ha-manager crm-command node-maintenance enable NODENAME
> >  ----
> > @@ -1142,6 +1154,15 @@ but only if it is either manually deactivated using the `ha-manager` CLI or if
> >  the manager-status is manually cleared.
> >
> >  .Disabling maintenance mode for a node
> > +
> > +_Using the web UI_
> > +
> > +Navigate to the Datacenter view, then select HA from the menu to show the HA
> > +Status pane. Select the lrm node that you want to disable maintenance mode for,
> > +then click the Disable Maintenance Mode button from the toolbar.
> > +
> > +_Using the CLI_
> > +
> >  ----
> >  # ha-manager crm-command node-maintenance disable NODENAME
> >  ----
>
>

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-08-26 16:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25  4:11 [pve-devel] [PATCH SERIES docs/ha-manager/manager] close #6144: add ui button + api for node maintenance mode Thomas Skinner
2025-08-25  4:11 ` [pve-devel] [PATCH ha-manager 1/2] add additional api field for lrm_mode in status check Thomas Skinner
2025-08-25  4:11 ` [pve-devel] [PATCH manager 1/2] add api path map for node HA endpoints Thomas Skinner
2025-08-26  9:38   ` Daniel Kral
2025-08-26 10:26     ` Thomas Lamprecht
2025-08-26 11:34       ` Daniel Kral
2025-08-25  4:11 ` [pve-devel] [PATCH docs 1/1] add docs for maintenance mode buttons in UI Thomas Skinner
2025-08-26  9:44   ` Daniel Kral
2025-08-26 16:05     ` Thomas Skinner [this message]
2025-08-27  7:50       ` Daniel Kral
2025-08-25  4:11 ` [pve-devel] [PATCH ha-manager 2/2] add api getter/setter for node maintenance mode Thomas Skinner
2025-08-26  9:38   ` Daniel Kral
2025-08-26 16:00     ` Thomas Skinner
2025-08-27  7:31       ` Thomas Lamprecht
2025-08-27  8:25       ` Daniel Kral
2025-08-27  9:20         ` Thomas Lamprecht
2025-08-29 20:13         ` Thomas Skinner
2025-09-01  8:52           ` Daniel Kral
2025-08-29 20:17     ` Thomas Skinner
2025-08-25  4:11 ` [pve-devel] [PATCH manager 2/2] add UI for node maintenance enable/disable Thomas Skinner
2025-08-26 10:00   ` Daniel Kral
2025-08-26 17:34     ` Thomas Skinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALn9RMe1E=h-4tiz4_M5nsFZGHMYDk_Bh3ug1J6DOXsvP2zL5g@mail.gmail.com' \
    --to=thomas@atskinner.net \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal