all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v3 0/3] disks: add checks, allow add_storage on other nodes
Date: Mon, 5 Sep 2022 11:50:38 +0200	[thread overview]
Message-ID: <9ff86f94-0e16-6132-cfe9-4321c69fa411@proxmox.com> (raw)
In-Reply-To: <20220819150121.1633021-1-a.lauterer@proxmox.com>

Code LGTM and tested fine
consider the series:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>




  parent reply	other threads:[~2022-09-05  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 15:01 Aaron Lauterer
2022-08-19 15:01 ` [pve-devel] [PATCH storage v3 1/3] diskmanage: add mounted_paths Aaron Lauterer
2022-08-19 15:01 ` [pve-devel] [PATCH storage v3 2/3] disks: die if storage name is already in use Aaron Lauterer
2022-08-19 15:01 ` [pve-devel] [PATCH storage v3 3/3] disks: allow add_storage for already configured local storage Aaron Lauterer
2022-09-05  9:50 ` Dominik Csapak [this message]
2022-09-13  8:06   ` [pve-devel] applied-series: [PATCH storage v3 0/3] disks: add checks, allow add_storage on other nodes Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ff86f94-0e16-6132-cfe9-4321c69fa411@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal