From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH common 1/2] fix #5454: net: check names for vlan bridge slave interfaces
Date: Mon, 11 Nov 2024 19:36:59 +0100 [thread overview]
Message-ID: <9f864e45-18b5-47ec-8836-c28de0b7403b@proxmox.com> (raw)
In-Reply-To: <20240925113930.92754-1-d.kral@proxmox.com>
Am 25.09.24 um 13:39 schrieb Daniel Kral:
> Adds a check for the name of VLAN bridge slave interfaces, which are
> created on non VLAN-aware bridges. These checks mimics what is done when
> parsing an interface name in iproute2 [0], which includes a name size
> check, an empty string check and checking for invalid characters.
>
> Without this check, creating a VLAN bridge slave interface, where the
> length of the string "<iface>.<vlanid>" will be greater than or equal to
> 16 characters, resulted in the following error message from `ip` itself:
>
>> Error: argument "<iface>.<vlanid>" is wrong: "name" not a valid ifname
>
> [0] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/utils.c?h=v6.1.0#n825
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> src/PVE/Network.pm | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
>
applied both patches, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-11 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 11:39 [pve-devel] " Daniel Kral
2024-09-25 11:39 ` [pve-devel] [PATCH common 2/2] net: add name checks when creating bridge and veth interfaces Daniel Kral
2024-11-11 18:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f864e45-18b5-47ec-8836-c28de0b7403b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.