From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: set file name for spice console download in chrome
Date: Fri, 23 Apr 2021 15:30:35 +0200 [thread overview]
Message-ID: <9f379462-35f3-ae48-d994-2ec524a8c6a3@proxmox.com> (raw)
In-Reply-To: <20210422074902.32118-1-l.stechauner@proxmox.com>
On 22.04.21 09:49, Lorenz Stechauner wrote:
> When the virt-viewer file is downloaded we already set
> a file name in Android, so the file type may be
> recognized. Also doing this in Chrome (and Chromium
> based browsers) allows users to "alyways open files of
> this type". So the browser automatically opens the
> console window without user interaction.
>
note, this seems like a bit of a crammed commit message text-width wise.
I amended that to match the text-width = 69, as it should neither be overly
long, nor really short.
If you use vim for writing those I suggest adding a hunk like the following
to your vimrc:
au FileType gitcommit setlocal tw=69
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> www/manager6/Utils.js | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>
applied, thanks! Behavior is really better this way in Chrome/Chromium.
My Firefox here already worked fine, so seems not required for it anyway.
prev parent reply other threads:[~2021-04-23 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:49 [pve-devel] " Lorenz Stechauner
2021-04-23 13:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f379462-35f3-ae48-d994-2ec524a8c6a3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.