From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] daemon: clean up middle process of double fork
Date: Tue, 3 Dec 2024 10:29:34 +0100 [thread overview]
Message-ID: <9e69d818-0978-4c25-b713-fa9ef93eec6a@proxmox.com> (raw)
In-Reply-To: <f568b9f6-fd6e-468e-9c61-a14bb3064675@proxmox.com>
Am 03.12.24 um 10:14 schrieb Dominik Csapak:
> my fear was that if there's something wrong with the middle child (e.g. something hangs)
> we'll never close the parent process either and have two old processes hanging around instead of one.
FWIW: You could still add a generous timeout. IMO it's less likely that we
hang here if the fork of the actual re-exec-self process worked, as then
the middle one just needs to exit, compared to the middle child not being
scheduling for a while after the work and before it exits, which is still
unlikely, but less so.
The old process being left-over itself was not a problem per se after all.
If you really fear something can hang then it would be much better to use
a timeout here and log an error, as that way it would be even more likely
to notice such bugs which a single probe using WNOHANG will always mask.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-03 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 15:37 Dominik Csapak
2024-12-02 9:04 ` Fabian Grünbichler
2024-12-02 16:47 ` Thomas Lamprecht
2024-12-03 9:14 ` Dominik Csapak
2024-12-03 9:29 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e69d818-0978-4c25-b713-fa9ef93eec6a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.