[pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable

[pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable

[Christoph Heiss]

It's just a stub method, so this gets never used.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxmox-firewall/tests/integration_tests.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-firewall/tests/integration_tests.rs b/proxmox-firewall/tests/integration_tests.rs
index 61a8062..1c014ad 100644
--- a/proxmox-firewall/tests/integration_tests.rs
+++ b/proxmox-firewall/tests/integration_tests.rs
@@ -87,7 +87,7 @@ impl FirewallConfigLoader for MockFirewallConfigLoader {
 
     fn bridge_firewall_config(
         &self,
-        bridge_name: &BridgeName,
+        _bridge_name: &BridgeName,
     ) -> Result<Option<Box<dyn std::io::BufRead>>, Error> {
         Ok(None)
     }
-- 
2.47.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable

[Christoph Heiss]

Ping, still applies.

On Tue Feb 25, 2025 at 11:28 AM CET, Christoph Heiss wrote:
> It's just a stub method, so this gets never used.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-firewall/tests/integration_tests.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-firewall/tests/integration_tests.rs b/proxmox-firewall/tests/integration_tests.rs
> index 61a8062..1c014ad 100644
> --- a/proxmox-firewall/tests/integration_tests.rs
> +++ b/proxmox-firewall/tests/integration_tests.rs
> @@ -87,7 +87,7 @@ impl FirewallConfigLoader for MockFirewallConfigLoader {
>
>      fn bridge_firewall_config(
>          &self,
> -        bridge_name: &BridgeName,
> +        _bridge_name: &BridgeName,
>      ) -> Result<Option<Box<dyn std::io::BufRead>>, Error> {
>          Ok(None)
>      }



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH proxmox-firewall] tests: integration: silence warning about unused variable

[Thomas Lamprecht]

Am 25.02.25 um 11:28 schrieb Christoph Heiss:
> It's just a stub method, so this gets never used.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-firewall/tests/integration_tests.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel