* [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable
@ 2025-02-25 10:28 Christoph Heiss
2025-03-26 9:25 ` Christoph Heiss
2025-03-26 9:39 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Heiss @ 2025-02-25 10:28 UTC (permalink / raw)
To: pve-devel
It's just a stub method, so this gets never used.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
proxmox-firewall/tests/integration_tests.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-firewall/tests/integration_tests.rs b/proxmox-firewall/tests/integration_tests.rs
index 61a8062..1c014ad 100644
--- a/proxmox-firewall/tests/integration_tests.rs
+++ b/proxmox-firewall/tests/integration_tests.rs
@@ -87,7 +87,7 @@ impl FirewallConfigLoader for MockFirewallConfigLoader {
fn bridge_firewall_config(
&self,
- bridge_name: &BridgeName,
+ _bridge_name: &BridgeName,
) -> Result<Option<Box<dyn std::io::BufRead>>, Error> {
Ok(None)
}
--
2.47.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable
2025-02-25 10:28 [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable Christoph Heiss
@ 2025-03-26 9:25 ` Christoph Heiss
2025-03-26 9:39 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Heiss @ 2025-03-26 9:25 UTC (permalink / raw)
To: Proxmox VE development discussion
Ping, still applies.
On Tue Feb 25, 2025 at 11:28 AM CET, Christoph Heiss wrote:
> It's just a stub method, so this gets never used.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-firewall/tests/integration_tests.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-firewall/tests/integration_tests.rs b/proxmox-firewall/tests/integration_tests.rs
> index 61a8062..1c014ad 100644
> --- a/proxmox-firewall/tests/integration_tests.rs
> +++ b/proxmox-firewall/tests/integration_tests.rs
> @@ -87,7 +87,7 @@ impl FirewallConfigLoader for MockFirewallConfigLoader {
>
> fn bridge_firewall_config(
> &self,
> - bridge_name: &BridgeName,
> + _bridge_name: &BridgeName,
> ) -> Result<Option<Box<dyn std::io::BufRead>>, Error> {
> Ok(None)
> }
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH proxmox-firewall] tests: integration: silence warning about unused variable
2025-02-25 10:28 [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable Christoph Heiss
2025-03-26 9:25 ` Christoph Heiss
@ 2025-03-26 9:39 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-03-26 9:39 UTC (permalink / raw)
To: Proxmox VE development discussion, Christoph Heiss
Am 25.02.25 um 11:28 schrieb Christoph Heiss:
> It's just a stub method, so this gets never used.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-firewall/tests/integration_tests.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-25 10:28 [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable Christoph Heiss
2025-03-26 9:25 ` Christoph Heiss
2025-03-26 9:39 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal