From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 container] fix #4192: revamp check for systemd version
Date: Wed, 16 Nov 2022 13:13:34 +0100 [thread overview]
Message-ID: <9cd03fec-b052-1f71-97cd-45b4f68c7a62@proxmox.com> (raw)
In-Reply-To: <a5d12f86-4a10-4d4f-067e-07defe050aa7@proxmox.com>
Am 08/11/2022 um 18:23 schrieb Thomas Lamprecht:
> Am 15/09/2022 um 13:52 schrieb Leo Nunner:
>> Instead of iterating through several folders, it might just be easier to
>> check the objdump output of /sbin/init and getting the version from there.
>> Resolving the /sbin/init symlink happens inside the chroot, but the
>> objdump from the host system is used, as to not run any untrusted
>> executables.
>>
>> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
>> ---
>> I think putting the subroutine to resolve the /sbin/init symlink into
>> Setup.pm makes the most sense, since this isn't realy a task for the
>> plugin.
>>
>> src/PVE/LXC/Setup.pm | 18 +++++++++++++++++-
>> src/PVE/LXC/Setup/Alpine.pm | 2 +-
>> src/PVE/LXC/Setup/Base.pm | 34 ++++++++++++++++++----------------
>> src/PVE/LXC/Setup/Devuan.pm | 2 +-
>> src/PVE/LXC/Setup/Plugin.pm | 2 +-
>> src/PVE/LXC/Setup/Unmanaged.pm | 2 +-
>> 6 files changed, 39 insertions(+), 21 deletions(-)
>>
>>
>
> applied, with a small followup for a few small white-space/indentation errors,
> otherwise nice work - thanks!
>
actually I did not yet pushed it out and rethought this, while I don't think that
the perm change is problematic w.r.t. backward compat in practice, it seems a bit
odd to argue for disk only, maybe we need to also check for CDROM, as cloudinit
*adds* a cdrom drive, so it may required that too.
But, to decide that I wanted to check our privilege docs, only to notice that
we do not mention the cloudinit one there at all, not great...
https://pve.proxmox.com/pve-docs/chapter-pveum.html#_privileges
Please check the dev history to see if Cloudinit is deemed enough to add the CDROM
or if we should add that priv to the check too, then re-send this with updated
commit message, the whitespace fixes and a docs patch.
next prev parent reply other threads:[~2022-11-16 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 11:52 Leo Nunner
2022-11-08 17:23 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-16 12:13 ` Thomas Lamprecht [this message]
2022-11-16 12:14 ` [pve-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd03fec-b052-1f71-97cd-45b4f68c7a62@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.