Re: [pve-devel] applied: [PATCH container 1/1] status: add some missing descriptions for status return properties

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 24/10/2024 um 17:05 schrieb Dominik Csapak:
> On 10/24/24 14:20, Thomas Lamprecht wrote:
>> Am 21/10/2024 um 11:15 schrieb Dominik Csapak:
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>> ---
>>>   src/PVE/LXC.pm | 43 ++++++++++++++++++++++++++++++++++++++++++-
>>>   1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>
>>
>> applied, thanks! FYI: I had to fix a duplicate key (see below) and made a few
>> small adjustments to the wording (not just your additions) as a separate follow-up.
>>
>>> +    netin => {
>>> +	description => "The amount of traffic that was sent to the guest since the process start,"
>>> +	    ." in bytes.",
>>> +	type => 'integer',
>>> +	optional => 1,
>>> +	renderer => 'bytes',
>>> +    },
>>> +    netin => {
>>
>> changed this to netout and folded that into your commit.
> 
> uff, thanks for that. seems i was too fast with the copy&paste...
> 

yeah, no worries, I just thought fixing that up on applying was overall
quicker compared to requesting a v2 (that I then might overlook/forget for
a few days).

> i wonder if our check target could catch something like that, but
> probably not i guess

Would be nice if perl could warn about those things, FWIW perlcritic does
not catches this either and perl just takes the last value.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel